KPluginSelector: use new KAboutPluginDialog
AcceptedPublic

Authored by kossebau on Tue, Oct 29, 8:04 PM.

Details

Reviewers
dfaure
apol
Group Reviewers
Frameworks
Summary

Depends on D25058

Diff Detail

Repository
R295 KCMUtils
Branch
useaboutplugindialog
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18327
Build 18345: arc lint + arc unit
kossebau created this revision.Tue, Oct 29, 8:04 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Oct 29, 8:04 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Tue, Oct 29, 8:04 PM
anthonyfieroni added inline comments.
src/kpluginselector.cpp
799–803

Can you guard for nullptr?

kossebau added inline comments.Wed, Oct 30, 2:02 PM
src/kpluginselector.cpp
799–803

The pluginEntry? That would be inconsistent with the rest of the code here, which does no such checks.
We should be relatively safe here, as the slot should be only triggered if the "About" button was clicked, in which case the button has the focus, and such will focusedIndex() deliver a valid index.

So IMHO this code is working in promised conditions, if they are not met, something else is principally broken.

dfaure accepted this revision.Wed, Nov 20, 8:48 AM
This revision is now accepted and ready to land.Wed, Nov 20, 8:48 AM