All the other platforms that have implemented this feature offer a little inline
explanation of what it is and what it does, but we do not. I think it makes sense to add
our own, since it's not a totally intuitive thing.
Details
Details
- Reviewers
ndavis zzag - Group Reviewers
VDG Plasma - Commits
- R119:af39f0aeaf93: [KCMs/Night Color] Explain Night Color feature inline
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I was going to suggest that we use the module subtitle for this, but it looks like we don't use those anymore.
Comment Actions
[KCMs/Night Color]
Plasma folks don't use such scopes. They prefer, correct me if I'm wrong, something like "[Night Color KCM]".
This comment was removed by davidedmundson.
Comment Actions
They prefer, correct me if I'm wrong, something like "[Night Color KCM]".
Plasma folks don't really have a good style sorted. You can find examples of 3 different styles.
It is a good point that we miss a consistency :/
but it also means no individual commit is wrong right now.
Comment Actions
Hmm, I feel the text here is a bit vague... "can make" should probably be "makes". Also, do people understand what "making colours warmer" means?
Comment Actions
I would hope so; warm vs cool colors is a grade-school-level-art-class concept . :) We also use "warm" and "Cool" for the slider's explanatory labels.
Comment Actions
The desktop effects KCM doesn't have a centered form layout like this one does. I tried a left-aligned label but it looked quite odd.