Modified breeze shadows
AbandonedPublic

Authored by niccolove on Oct 12 2019, 2:11 PM.

Details

Reviewers
None
Group Reviewers
VDG
Summary

I have received negative feedback (and I agree with it) on the current state of breeze shadows: they are quite dark, narrow, and feel unnatural. I tried to adress that by making shadows more sparse and a bit lighter especially on the angles while trying to keep it distinguishable when on white background. I received some positive feedback on these shadows from T10891 and the VDG channel.
More specifically, I changed dialogs/background.svg and widgets/panel-background.svg to have a) longer linear gradients and b) radial gradients instead of linear on the four sides to make the center darker than the angles.

Test Plan



Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
breeze-shadows (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18194
Build 18212: arc lint + arc unit
niccolove created this revision.Oct 12 2019, 2:11 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 12 2019, 2:11 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
niccolove requested review of this revision.Oct 12 2019, 2:11 PM
niccolove edited the test plan for this revision. (Show Details)Oct 12 2019, 2:12 PM
niccolove added a reviewer: VDG.

Uhm, I probably got Scour wrong. Sorry.

Please write what you've changed and why

niccolove edited the summary of this revision. (Show Details)Oct 12 2019, 2:52 PM
niccolove edited the test plan for this revision. (Show Details)
niccolove updated this revision to Diff 67790.Oct 12 2019, 2:57 PM

Used scour on svg files

I'm sorry, when I use scour on svg files, it looks like git does not recognize that the file has changed. How can I fix that?

I'm sorry, when I use scour on svg files, it looks like git does not recognize that the file has changed. How can I fix that?

That means that the files actually haven't changed compared to the prior version. It looks like the diff is messed up and is using the scoured version as the base rather than the latest git master.

niccolove updated this revision to Diff 67852.Oct 13 2019, 4:21 PM

Re-done the dialogs/background.svg

niccolove updated this revision to Diff 67853.Oct 13 2019, 4:27 PM

Re-done the widgets/panel-background.svg

niccolove edited the test plan for this revision. (Show Details)Oct 13 2019, 4:31 PM

I'm sorry, when I use scour on svg files, it looks like git does not recognize that the file has changed. How can I fix that?

That means that the files actually haven't changed compared to the prior version. It looks like the diff is messed up and is using the scoured version as the base rather than the latest git master.

It now shows me a diff, is relatively to master or to my previous svg? in that case, I can do another diff without messing up (hopefully)

filipf added a subscriber: filipf.Oct 13 2019, 5:03 PM

b) radial gradients instead of linear on the four sides to make the center darker than the angles.

Other than this, they look great to me. I think they should be uniformly dispersed.

One of the things with shadows is that the user shouldn't really notice them. With the radial style I can't help but notice there's shadows missing in the corners.

Luwx added a subscriber: Luwx.EditedOct 14 2019, 1:39 AM

Making good looking pure svg box shadows is a bit tricky.

A while back I tried to create one:

The left one uses blur (like breeze decoration does) and the right uses gradients with quite a few stops to emulate the blurred square (I don't know if this has any effect on performance), radial gradients were used only in the corners.

It this is of any help, here is the svg:

b) radial gradients instead of linear on the four sides to make the center darker than the angles.

Other than this, they look great to me. I think they should be uniformly dispersed.

One of the things with shadows is that the user shouldn't really notice them. With the radial style I can't help but notice there's shadows missing in the corners.

What do you think?

In D24593#546731, @Luwx wrote:

Making good looking pure svg box shadows is a bit tricky.

A while back I tried to create one:

The left one uses blur (like breeze decoration does) and the right uses gradients with quite a few stops to emulate the blurred square (I don't know if this has any effect on performance), radial gradients were used only in the corners.

It this is of any help, here is the svg:

Thanks, that's interesting. May I ask why did you use multiple linear gradients instead of a big linear one?

niccolove edited the test plan for this revision. (Show Details)Sat, Oct 19, 2:58 PM

Is this ready for formal review now or are you still tweaking and/or soliciting comments?

niccolove updated this revision to Diff 68626.Wed, Oct 23, 7:55 PM

Made missing shadow on corners less noticeable on widgets shadows

Is this ready for formal review now or are you still tweaking and/or soliciting comments?

Ready for review :-)

Needs a rebase on master. It doesn't apply for me.

niccolove updated this revision to Diff 68788.Sat, Oct 26, 2:11 PM

Rebase on master - test

Needs a rebase on master. It doesn't apply for me.

Does it apply now? If not, I messed up something and I will just reset to master and add the svgs again.

Still not working, sorry.