Restore cursor thumbnailer
Changes PlannedPublic

Authored by broulik on Sat, Oct 5, 7:50 PM.

Details

Reviewers
fredrik
ngraham
Group Reviewers
Plasma
Summary

Baiscally just find xlib and change the link targets.
There's no xcb equivalent for plain cursor file loading.

BUG: 387660
FIXED-IN: 19.12.0

Test Plan


It doesn't appear to use Display for just reading the files, so doesn't need any X11 guards? Thumbnails work fine in Dolphin on Wayland.

Diff Detail

Repository
R320 KIO Extras
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Sat, Oct 5, 7:51 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptSat, Oct 5, 7:51 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Sat, Oct 5, 7:51 PM
ngraham accepted this revision.Mon, Oct 7, 3:39 PM
ngraham added a subscriber: ngraham.

Nice.

This revision is now accepted and ready to land.Mon, Oct 7, 3:39 PM
adridg added a subscriber: adridg.Fri, Oct 11, 12:32 PM
adridg added inline comments.
thumbnail/CMakeLists.txt
149

X11_Xcursor_FOUND, since X11 can be found without Xcursor.

broulik planned changes to this revision.Tue, Oct 15, 1:44 PM