Restore cursor thumbnailer
ClosedPublic

Authored by broulik on Oct 5 2019, 7:50 PM.

Details

Summary

Baiscally just find xlib and change the link targets.
There's no xcb equivalent for plain cursor file loading.

BUG: 387660
FIXED-IN: 20.04.0

Test Plan


It doesn't appear to use Display for just reading the files, so doesn't need any X11 guards? Thumbnails work fine in Dolphin on Wayland.

Diff Detail

Repository
R320 KIO Extras
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Oct 5 2019, 7:51 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptOct 5 2019, 7:51 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Oct 5 2019, 7:51 PM
ngraham accepted this revision.Oct 7 2019, 3:39 PM
ngraham added a subscriber: ngraham.

Nice.

This revision is now accepted and ready to land.Oct 7 2019, 3:39 PM
adridg added a subscriber: adridg.Oct 11 2019, 12:32 PM
adridg added inline comments.
thumbnail/CMakeLists.txt
149

X11_Xcursor_FOUND, since X11 can be found without Xcursor.

broulik planned changes to this revision.Oct 15 2019, 1:44 PM
broulik updated this revision to Diff 72476.Dec 31 2019, 11:58 AM
broulik edited the summary of this revision. (Show Details)
  • Find XCursor specifically
This revision is now accepted and ready to land.Dec 31 2019, 11:58 AM
broulik requested review of this revision.Dec 31 2019, 12:28 PM
davidedmundson accepted this revision.Jan 1 2020, 4:58 PM
This revision is now accepted and ready to land.Jan 1 2020, 4:58 PM
This revision was automatically updated to reflect the committed changes.