make editMode a corona global property

Authored by mart on Sep 26 2019, 10:29 AM.



The plans are to switch on/off the whole plasma shell into edit mode.
For this it needs to be a global corona property, rather then just
Plasmashell would expose a dbus call to set it from systemsettings

Test Plan

plasmoid.editMode=true still works

Diff Detail

R242 Plasma Framework (Library)
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Sep 26 2019, 10:29 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 26 2019, 10:29 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Sep 26 2019, 10:29 AM
broulik added inline comments.

I think you should check for SystemImmutable here (KIOSK)


Nevermind, it just moved :)

mart added inline comments.Sep 26 2019, 10:31 AM

m_containment->corona()->setEditMode(edit) will fail if the immutability isn't mutable. so both systemimmutable and userimmutable

mart updated this revision to Diff 66904.Sep 26 2019, 4:20 PM
  • global actions needed for new edit mode toolbox

Could we put the word "wallpaper" somewhere in the global edit mode toolbox to improve wallpaper changing discoverability? I recall this in a mockup shown at the Plasma & Usability & Productivity sprint.

ngraham accepted this revision.Sep 26 2019, 5:32 PM

Never mind, that's not in this patch.

This revision is now accepted and ready to land.Sep 26 2019, 5:32 PM
This revision was automatically updated to reflect the committed changes.