- Group Reviewers
- R266:010c34f0e7c5: Add enablefont and disablefont icon for kfontinst KCM
Oof, all of the font icons that contain an 'A' need to be cleaned up someday. The 'A's aren't even 16px tall in the 22px icons and the line thickness and alignment is all over the place. I guess that's something for another patch. For now, we should maintain consistency with the existing font icons.
I just noticed that the "No" symbol is backwards. Once you fix that and the hardcoded colors, this patch will be ready to land.
I was asked to remove the hard code color like: fill="currentColor" and fill="#da4453". But I see other icons have something like style="fill:currentColor". Can anyone tell me correct way of applying colors?
I still feel like I'd prefer the checkmark to be green. I also feel like I understand the argument that red isn't the best color to use for disabling something since it isn't destructive. Maybe we should use the orange color for that?
Definitely need clarification in the HIG.