[kfontinst] Port to use icons from the icon theme and make HiDPI aware
Needs ReviewPublic

Authored by guoyunhe on Wed, Sep 11, 9:01 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Summary

Use QIcon instead of QPixmap for icons. Use QPushButton for the filter menu instead of a QLabel.

Depends on D23942

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16561
Build 16579: arc lint + arc unit
guoyunhe created this revision.Wed, Sep 11, 9:01 AM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Sep 11, 9:01 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Wed, Sep 11, 9:01 AM
guoyunhe edited the summary of this revision. (Show Details)Wed, Sep 11, 9:01 AM
guoyunhe added a reviewer: Plasma.
guoyunhe updated this revision to Diff 65841.EditedWed, Sep 11, 10:15 AM

Fix the font preview size in HiDPI

guoyunhe updated this revision to Diff 66074.Sat, Sep 14, 5:43 PM

Change icon name. To match patch D23942

ngraham retitled this revision from kfontinst HiDPI icons to [kfontinst] Port to use icons from the icon theme.Sat, Sep 14, 7:37 PM
ngraham edited the summary of this revision. (Show Details)
ngraham retitled this revision from [kfontinst] Port to use icons from the icon theme to [kfontinst] Port to use icons from the icon theme and make HiDPI aware.
ngraham requested changes to this revision.Sat, Sep 14, 7:50 PM
ngraham added a subscriber: ngraham.

Either use a ToolButton for the filter feature, or turn "Scan for duplicate fonts" into a PushButton, so they match one way or another.

This revision now requires changes to proceed.Sat, Sep 14, 7:50 PM

I changed it to QToolButton, but it still look different:

guoyunhe updated this revision to Diff 66101.EditedSun, Sep 15, 6:28 AM

Unify button look