+1
Next time please also add VDG as a subsriber and reviewer if there is a UI related change :-)

I didn't know what to do with this

...check to see if the plugin we've just created is the Details plugin,...

Also the "Generator" should probably go back where it was right?

More or less! A new things:

1. Don't forget to add the function definition for KPropertiesDialog::insertPluginAt(KPropertiesDialogPlugin *plugin, int index) to the header file
2. Revert the change where you moved that section; it's now unnecessary
3. Instead of unconditionally doing q->insertPluginAt(plugin, 1);, you'd want to do something more like this:

if (plugin == "details"  /* this is pseudocode */) {
    q->insertPluginAt(plugin, 1);
} else {
    q->insertPlugin(plugin);
}

I'm actually not sure how to check for what the plugin is though. Maybe someone from Frameworks can help.

Ping.

3. Instead of unconditionally doing q->insertPluginAt(plugin, 1);, you'd want to do something more like this:

if (plugin == "details"  /* this is pseudocode */) {
    q->insertPluginAt(plugin, 1);
} else {
    q->insertPlugin(plugin);
}

I'm actually not sure how to check for what the plugin is though. Maybe someone from Frameworks can help.

This is mostly done but we still need to do this the check, but neither me nor @ngraham know how to do it.

Any progress on this?

In D23926#538778, @mthw wrote:

3. Instead of unconditionally doing q->insertPluginAt(plugin, 1);, you'd want to do something more like this:

if (plugin == "details"  /* this is pseudocode */) {
    q->insertPluginAt(plugin, 1);
} else {
    q->insertPlugin(plugin);
}

I'm actually not sure how to check for what the plugin is though. Maybe someone from Frameworks can help.

This is mostly done but we still need to do this the check, but neither me nor @ngraham know how to do it.

An alternative would be to move the whole block inserting KPropertiesDialog/Plugin before "KChecksumsPlugin".
AFAIK there are only two KPropertiesDialog/Plugin, so this would move details and baloo both of before the rest, which is fine IMO.
You would not need an integer parameter to insertPluginAt anymore.

@meven So, the first version of this diff is good enough?

In D23926#624753, @mthw wrote:

@meven So, the first version of this diff is good enough?

Well no I missed @ngraham points that still stands.
And your current code result with the same effect anyway as long as we miss the condition "only if details plugin"

We don't have a "clean" way to do this.
One way to do the trick would be to look at the KService::Ptr &ptr icon() which will return "baloo" or the storageId() that should give "baloofilepropertiesplugin.desktop" for the baloo details plugin.
The storageId method should be preferred as less likely to change.

if (ptr->serviceId() == QStringLitteral("baloofilepropertiesplugin")) {
    q->insertPluginAt(plugin,1);
} else {
    q->insertPlugin(plugin);
}

Should be close enough to a working somewhat satisfying solution

I hope this helps.

This needs a rebase.

Ping :-)