Add two special cases url recentlyused:/files and recentlyused:/folders
ClosedPublic

Authored by meven on Sep 5 2019, 3:51 PM.

Diff Detail

Repository
R320 KIO Extras
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16146
Build 16164: arc lint + arc unit
meven created this revision.Sep 5 2019, 3:51 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptSep 5 2019, 3:51 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Sep 5 2019, 3:51 PM
ngraham accepted this revision.Sep 5 2019, 3:59 PM

After applying the full patchset, this works great. It's exactly what I was hoping for! 👏

This revision is now accepted and ready to land.Sep 5 2019, 3:59 PM
meven updated this revision to Diff 65467.Sep 5 2019, 5:58 PM

Rephrase 'Recent Folders' to 'Recent Locations'

ivan accepted this revision.Sep 5 2019, 6:46 PM
meven updated this revision to Diff 65470.Sep 5 2019, 6:52 PM

Add some const

meven updated this revision to Diff 65473.Sep 5 2019, 7:02 PM

Replace /folders by /locations, add some documentation

meven updated this revision to Diff 65484.Sep 5 2019, 8:36 PM

grammar

meven updated this revision to Diff 65492.Sep 6 2019, 3:25 AM

Use Terms::Type::directories()

meven updated this revision to Diff 65597.Sep 7 2019, 8:25 PM

Use new folder-open-recent for /locations

ngraham accepted this revision.Sep 7 2019, 8:38 PM
ivan accepted this revision.Sep 7 2019, 9:51 PM
meven added inline comments.Sep 10 2019, 7:28 PM
recentlyused/recentlyused.cpp
98

Should we allow the filtering through type with /files path ?
I am thinking I should change that.

ngraham added inline comments.Sep 10 2019, 7:33 PM
recentlyused/recentlyused.cpp
98

Sure, sounds like a neat bonus feature.

meven updated this revision to Diff 65959.Sep 13 2019, 9:16 AM

Allow users to use ?type filter with /files path

meven marked 2 inline comments as done.Sep 13 2019, 9:17 AM

I will land this soonish if no one has any objections.

Please do! It's already accepted. :)

meven updated this revision to Diff 67102.Oct 1 2019, 7:03 AM

Correct ?type use with /files : ?type overrules /files, since they are aggregated with ORs

meven added a comment.Oct 1 2019, 7:04 AM

The /folders path is /locations in fact

This revision was automatically updated to reflect the committed changes.