Use the same list style as the Virtual Desktops KCM and Kirigami actions with tooltips.
Also removes the info button. The copyright info can now be accessed by clicking on the item.
BUG: 409693
BUG: 335197
BUG: 335198
Details
Details
Together with D22827:
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- arcpatch-D22830
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 14649 Build 14667: arc lint + arc unit
Comment Actions
I think it would be even better if you made it look exactly like the Virtual Desktops KCM:
- no alternating item backgrounds
- same item category header style (custom AbstractListItem)
- inline action item buttons
Comment Actions
Rework
- Use virtual desktops kcm list style and Kirigami actions
- Remove info button. The copyright info can be accessed by clicking on the item
Comment Actions
Wow, this looks and feels radically better. One way to improve it even a bit more in my opinion would be to make the header text a bit bigger. I believe @filipf suggest Heading size 3, which looked good to me.
Comment Actions
- Make QML imports consistent (T10862)
- Improve filter button
- Use heading level 3 for category headers
Comment Actions
Nice work.
There's a binding loop that doesn't look trivial to solve, but doesn't seem to affect anything.
file:///usr/share/kpackage/kcms/kcm_kwin_effects/contents/ui/main.qml:96:19: QML SwipeListItem: Binding loop detected for property "implicitHeight"
EDIT: on further investigation the binding loop is triggered for /usr/lib/qt/qml/org/kde/kirigami.2/templates/SwipeListItem.qml
Comment Actions
There's something weird with the frame that the list is inside. The top or bottom edges get cut off when the list is scrolled:
Comment Actions
There's something weird with the frame that the list is inside. The top or bottom edges get cut off when the list is scrolled:
Unrelated to this patch/KCM:
Comment Actions
We also need a patch for the Virtual Desktops KCM to make the category headers consistent.