Make QML imports consistent
Open, LowPublic
Actions

Description

QML imports are currently not all consistent.
We should use this example as a base (versions can of course be different, only use needed imports) and apply it everywhere:

import QtQuick 2.12
import QtQuick.Controls 2.12 as QQC2
import QtQuick.Dialogs 1.3 as QtDialogs
import QtQuick.Layouts 1.12

import org.kde.kirigami 2.10 as Kirigami
import org.kde.plasma.components 2.0 as PlasmaComponents2
import org.kde.plasma.components 3.0 as PlasmaComponents3
import org.kde.plasma.core 2.0 as PlasmaCore
import org.kde.plasma.extras 2.0 as PlasmaExtras

Details

Differential Revisions: D21417: [ActionListItem] Make QML imports and tooltip consistent
D22830: [kcmkwin/kwineffects] Rework the Effects KCM
D22896: Port System Settings sidebar to QQC2
D22933: [kcmkwin/kwindesktop] Improve the look of the Virtual Desktops KCM UI
D22940: Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent

Related Objects

Mentioned In: D23712: [Cuttlefish] Overhaul program, use Kirigami
D23718: WIP: Beginning of the Baloo/Search KCM Rewrite
R124:b42479962795: Port System Settings sidebar to QQC2
R120:b4ccffec69ec: Add label to the lockscreen config's "Show media controls" checkbox and make…
R108:ee05fd4dc7f8: [kcmkwin/kwindesktop] Improve the look of the Virtual Desktops KCM UI
D22896: Port System Settings sidebar to QQC2
D22830: [kcmkwin/kwineffects] Rework the Effects KCM
D20598: Port kcm energy info to kirigami 2, fix colors issues
D21675: mobile: fully port to QQC2
R134:7b778dbe90fe: [ActionListItem] Make QML imports and tooltip consistent
D21417: [ActionListItem] Make QML imports and tooltip consistent
Mentioned Here: D20953: New Home Screen for KTouch

GB_2 created this task.Apr 29 2019, 7:02 PM

GB_2 updated the task description. (Show Details)

Like QtQuickControls, PlasmaComponents comes multiple versions: 2 and 3. Maybe the following?

import org.kde.plasma.components 2.0 as PC2
import org.kde.plasma.components 2.0 as PC3

In T10862#183370, @ngraham wrote:
Like QtQuickControls, PlasmaComponents comes multiple versions: 2 and 3. Maybe the following?
import org.kde.plasma.components 2.0 as PC2
import org.kde.plasma.components 2.0 as PC3

Ok, the only problem I see is that we already use PlasmaComponents in all places.

Oh, and then PlasmaCore (PC) would conflict with PlasmaComponents (PC).

We'll just leave the Plasma names, but add the major version number to the PlasmaComponents import name.

GB_2 updated the task description. (Show Details)Apr 29 2019, 7:15 PM

GB_2 triaged this task as Low priority.Apr 30 2019, 8:29 PM

GB_2 updated the task description. (Show Details)

GB_2 updated the task description. (Show Details)May 1 2019, 9:21 AM

What about PlasmaComponents3?