[kcmkwin/kwineffects] Rework the Effects KCM
ClosedPublic

Authored by davidre on Tue, Jul 30, 2:23 PM.

Details

Summary

Use the same list style as the Virtual Desktops KCM and Kirigami actions with tooltips.
Also removes the info button. The copyright info can now be accessed by clicking on the item.

BUG: 409693
BUG: 335197
BUG: 335198

Test Plan

Together with D22827:

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Tue, Jul 30, 2:23 PM
Restricted Application added a project: KWin. · View Herald TranscriptTue, Jul 30, 2:23 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidre requested review of this revision.Tue, Jul 30, 2:23 PM
davidre edited the test plan for this revision. (Show Details)Tue, Jul 30, 2:24 PM
davidre added a reviewer: KWin.
davidre added a reviewer: VDG.Tue, Jul 30, 2:28 PM
filipf accepted this revision.Tue, Jul 30, 3:47 PM
filipf added a subscriber: filipf.

It's more spacious with better content separation, looks better altogether, +1

This revision is now accepted and ready to land.Tue, Jul 30, 3:47 PM
davidre edited the summary of this revision. (Show Details)Tue, Jul 30, 6:28 PM
GB_2 added a subscriber: GB_2.Thu, Aug 1, 1:17 PM

I think it would be even better if you made it look exactly like the Virtual Desktops KCM:

  • no alternating item backgrounds
  • same item category header style (custom AbstractListItem)
  • inline action item buttons
davidre updated this revision to Diff 62920.Thu, Aug 1, 5:54 PM
davidre retitled this revision from [kcmkwin/kwineffects] Use SwipeListItems to [kcmkwin/kwineffects] Rework the Effects KCM.
davidre edited the summary of this revision. (Show Details)

Rework

  • Use virtual desktops kcm list style and Kirigami actions
  • Remove info button. The copyright info can be accessed by clicking on the item
davidre updated this revision to Diff 62921.Thu, Aug 1, 5:55 PM

Arc mess up

davidre edited the test plan for this revision. (Show Details)Thu, Aug 1, 5:55 PM
GB_2 updated this revision to Diff 62924.Thu, Aug 1, 6:36 PM

Improve tooltips and filter button behavior

davidre updated this revision to Diff 62926.Thu, Aug 1, 6:50 PM

That should work

GB_2 accepted this revision.Thu, Aug 1, 6:54 PM
davidre updated this revision to Diff 62929.Thu, Aug 1, 6:59 PM

restore me as the author

ngraham added a subscriber: ngraham.Thu, Aug 1, 7:35 PM

Wow, this looks and feels radically better. One way to improve it even a bit more in my opinion would be to make the header text a bit bigger. I believe @filipf suggest Heading size 3, which looked good to me.

GB_2 updated this revision to Diff 62960.Fri, Aug 2, 8:13 AM
  • Make QML imports consistent (T10862)
  • Improve filter button
  • Use heading level 3 for category headers
GB_2 edited the test plan for this revision. (Show Details)Fri, Aug 2, 8:16 AM
GB_2 updated this revision to Diff 62962.Fri, Aug 2, 8:49 AM

Fix 2nd filter name

filipf accepted this revision.EditedFri, Aug 2, 8:54 AM

Nice work.

There's a binding loop that doesn't look trivial to solve, but doesn't seem to affect anything.

file:///usr/share/kpackage/kcms/kcm_kwin_effects/contents/ui/main.qml:96:19: QML SwipeListItem: Binding loop detected for property "implicitHeight"

EDIT: on further investigation the binding loop is triggered for /usr/lib/qt/qml/org/kde/kirigami.2/templates/SwipeListItem.qml

There's something weird with the frame that the list is inside. The top or bottom edges get cut off when the list is scrolled:

GB_2 updated this revision to Diff 62972.Fri, Aug 2, 2:08 PM

Correctly position menu

GB_2 added a comment.Fri, Aug 2, 2:13 PM

There's something weird with the frame that the list is inside. The top or bottom edges get cut off when the list is scrolled:

Unrelated to this patch/KCM:

ngraham accepted this revision.Fri, Aug 2, 2:13 PM

Actually never mind, that seems to be a pre-existing issue.

GB_2 edited the summary of this revision. (Show Details)Fri, Aug 2, 9:15 PM
GB_2 added a project: VDG.

We also need a patch for the Virtual Desktops KCM to make the category headers consistent.

davidedmundson accepted this revision.Fri, Aug 2, 10:33 PM

And for System Settings' sidebar, too.

This revision was automatically updated to reflect the committed changes.