Thanks @hpereiradacosta! This looks fantastic. Adding @ndavis and @filipf for comment since they've been working on this project too from other angles.

In D22138#487668, @ngraham wrote:

Thanks @hpereiradacosta! This looks fantastic. Adding @ndavis and @filipf for comment since they've been working on this project too from other angles.

No need for thanks @ngraham, I am not doing this for you and this is irrelevant in terms of review.

Umm OK, sorry if I've said something wrong.

Very nice! In conjunction with Marco's patch (D22083), I now see the following for Dolphin's settings window:

I notice that your screenshot depicts the sidebar with no top, bottom, or left margins, which is the indended appearance. Is that the result of some other required patch I haven't applied yet, or did I do something wrong?

In D22138#490967, @ndavis wrote:

Since this apparently doesn't need review,

This is not what I said. What I said is "thanks, it looks fantastic" is not a proper review and hence irrelevant. What I expect for a proper review is

• does the patch achieve the behavior matching its title, and is it the intended behavior
• does the code look legit (compiles, properly formatted, etc.)
• is there a better way to achieve the same
• does the patch break other things, and how can it be improved so that it doesn't

If you can provide such a review I'd be happy to modify the patch accordingly.

I'll resign.

In D22138#490976, @ngraham wrote:

Very nice! In conjunction with Marco's patch (D22083), I now see the following for Dolphin's settings window:

I notice that your screenshot depicts the sidebar with no top, bottom, or left margins, which is the indended appearance. Is that the result of some other required patch I haven't applied yet, or did I do something wrong?

Sorry. My bad. Yes, my own copy included other changes beyond my patch and Marco's, resulting in the zero margins. The screenshot you post is the correct one. Thanks.
The remaining margin issue, handled at the layout level, either in breeze or in kpagedialog, should be a separate patch.

The purpose of this one is to fix the margin issues which cannot be handled at the layout level.

In D22138#491018, @hpereiradacosta wrote:

In D22138#490967, @ndavis wrote:

Since this apparently doesn't need review,

This is not what I said. What I said is "thanks, it looks fantastic" is not a proper review and hence irrelevant. What I expect for a proper review is

• does the patch achieve the behavior matching its title, and is it the intended behavior
• does the code look legit (compiles, properly formatted, etc.)
• is there a better way to achieve the same
• does the patch break other things, and how can it be improved so that it doesn't If you can provide such a review I'd be happy to modify the patch accordingly.

I'll resign.

In that case, I will review this.

Indeed. This is a problem. As soon as treeviews are animated Qt makes a pixmap copy of the treeview viewport. This does not include the blue line on the side, which is painted in the frame, below the (transparent) viewport. Will investigate further.

In D22138#491173, @hpereiradacosta wrote:

Indeed. This is a problem. As soon as treeviews are animated Qt makes a pixmap copy of the treeview viewport. This does not include the blue line on the side, which is painted in the frame, below the (transparent) viewport. Will investigate further.

would still adding a pixel on the right work around the issue?

In D22138#491285, @mart wrote:

In D22138#491173, @hpereiradacosta wrote:

Indeed. This is a problem. As soon as treeviews are animated Qt makes a pixmap copy of the treeview viewport. This does not include the blue line on the side, which is painted in the frame, below the (transparent) viewport. Will investigate further.

would still adding a pixel on the right work around the issue?

Yes, left or right depending of RTL. I have a working patch (I think). Will upload in a minute.

Works for me. Tested RTL with kate --reverse.