Differential D22011

Add MenuSeparator
ClosedPublic
Actions

Authored by astippich on Jun 22 2019, 6:49 PM.

Details

Reviewers

mart
apol
ngraham

Commits

R858:6eb266c3d4fc: Add MenuSeparator

Summary

Make the MenuSeparator span the full width of the menu
like in QWidget-based menus

Diff Detail

Repository

R858 Qt Quick Controls 2: Desktop Style

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

astippich created this revision.Jun 22 2019, 6:49 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJun 22 2019, 6:49 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

astippich requested review of this revision.Jun 22 2019, 6:49 PM

Harbormaster completed remote builds in B13175: Diff 60391.Jun 22 2019, 6:49 PM

Related to D21944
Menu now looks like

before:

ngraham added inline comments.Jun 22 2019, 11:21 PM

org.kde.desktop/MenuSeparator.qml
38	@mart does this need to be multiplied by the device pixel ratio to account for fractional scale factors? I forget.

In the after picture I'm noticing that the separator is 1px outside the frame when the menus is over a dark bg.

apol added inline comments.Jun 23 2019, 9:30 AM

org.kde.desktop/MenuSeparator.qml
38	It shouldn't need any height at all.

ngraham accepted this revision.Jun 23 2019, 9:33 AM

ngraham added inline comments.

org.kde.desktop/MenuSeparator.qml
38	Oh duh, I was thinking it was a Rectangle, but it's a Kirigami.Separator

This revision is now accepted and ready to land.Jun 23 2019, 9:33 AM

remove unneeded height

Harbormaster completed remote builds in B13192: Diff 60433.Jun 23 2019, 10:21 AM

LGTM

To be honest, I would expect this to be the actual logic and Kirigami.Separator just use MenuSeparator, but maybe it's something we can look into in the future.

Closed by commit R858:6eb266c3d4fc: Add MenuSeparator (authored by astippich). · Explain WhyJun 23 2019, 6:07 PM

This revision was automatically updated to reflect the committed changes.

ngraham added a dependent revision: D21943: Port the application menu to qqc2.Jun 28 2019, 2:27 PM

Revision Contents
Changeset List

			Path	Packages
A	M		org.kde.desktop/MenuSeparator.qml (38 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	60391	5b3129f		Jun 22 2019, 6:49 PM	★	★
Diff 2	60433	5b3129f	- remove unneeded height	Jun 23 2019, 10:21 AM	★	★
Diff 3	60528	33a13d1	R858:6eb266c3d4fca0c246d3fac48a2471190599e109	Jun 23 2019, 6:06 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
9f5488e4cb73	6357bd8947ad	97828b48a1c0	Alexander Stippich	remove unneeded height	Jun 23 2019, 10:21 AM
97828b48a1c0	c55e782a63bf	044fd9f13a3c	Alexander Stippich	Add MenuSeparator (Show More…)	Jun 22 2019, 6:47 PM
044fd9f13a3c	935e68cd5be9	7504a8570afc	Alexander Stippich	more tweaks	Jun 22 2019, 6:47 PM
7504a8570afc	93af6f040efd	4d6526f385f0	Alexander Stippich	tweak	Jun 22 2019, 6:43 PM
4d6526f385f0	1c1ced95161c	5b3129f40521	Alexander Stippich	Add MenuSeparator	Jun 22 2019, 6:00 PM

Status	Author	Revision
Closed	astippich	D21943 Port the application menu to qqc2
Closed	astippich	D21944 Show shortcut in menu item when specified
Closed	astippich	D22011 Add MenuSeparator

Diff 60528

View Options

org.kde.desktop/MenuSeparator.qml