Show the shortcut as text for menu items when
they are given via an action
BUG: 405541
Details
Details
- Reviewers
mart ngraham apol - Commits
- R858:721c348d1a1e: Show shortcut in menu item when specified
Diff Detail
Diff Detail
- Repository
- R858 Qt Quick Controls 2: Desktop Style
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This is required to port the menu of Elisa to qqc2 (D21943)
qqc1 version
qqc2 version without this patch
qqc2 with this patch
| org.kde.desktop/MenuItem.qml | ||
|---|---|---|
| 98 | label.color? | |
| 103 | Use Layout.rightMargin on the shortcut object. | |
| org.kde.desktop/MenuItem.qml | ||
|---|---|---|
| 103 | I think the original approach to use an Item was correct, both because now it looks wrong, but also because using an Item makes the layout automatically RTL compatible, while setting the right padding property requires conditional handling for the reversed case. | |
Comment Actions
Unfortunately, even with this reverted change I know get a wrong menu separator. I don't know what was different before...
Since it was also there without this patch (see screenshot), it is probably a different issue which needs investigation