Differential D21901

Calendar events: allow plugins to show event details
ClosedPublic
Actions

Authored by dvratil on Jun 19 2019, 3:37 PM.

Details

Reviewers

mart
apol

Group Reviewers

Frameworks

Commits

R296:811e78ef0ee3: Calendar events: allow plugins to show event details

Summary

This adds new method to the plugin API that will allow plugins to show
event details when user clicks on the event, for example by
opening KOrganizer.

Diff Detail

Repository

R296 KDeclarative

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dvratil created this revision.Jun 19 2019, 3:37 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJun 19 2019, 3:37 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

dvratil requested review of this revision.Jun 19 2019, 3:37 PM

Harbormaster completed remote builds in B12973: Diff 60065.Jun 19 2019, 3:37 PM

dvratil added a reviewer: Frameworks.Jun 19 2019, 3:37 PM

dvratil added a dependent revision: D21902: Calendar: add method to show event details.Jun 19 2019, 3:42 PM

Fix ABI compatibility

Harbormaster completed remote builds in B12976: Diff 60068.Jun 19 2019, 3:43 PM

dvratil added a dependent revision: D21906: Events plugin: implement the new showEvent() API.Jun 19 2019, 3:57 PM

dvratil added a reviewer: mart.Jun 27 2019, 2:12 PM

Adding a new virtual to a non-leaf class is never ABI compatible.

So, we are doomed to CalendarEventsPluginV2? *sadpanda*

Unrelatedly, if you don't already have KOrganizer installed, it would be really nice if clicking on a day in the calendar showed a message that you need to install KOrganizer to create events, with a button that installs it via PackageKit when clicked on. That would be really cool.

Make the change truly API and ABI compatible

Harbormaster completed remote builds in B13443: Diff 60890.Jun 30 2019, 9:48 PM

dvratil mentioned this in D21902: Calendar: add method to show event details.Jun 30 2019, 9:49 PM

dvratil mentioned this in D21906: Events plugin: implement the new showEvent() API.

Ping?

apol accepted this revision.Jul 15 2019, 1:08 AM

This revision is now accepted and ready to land.Jul 15 2019, 1:08 AM

apol added inline comments.Jul 15 2019, 1:08 AM

src/calendarevents/calendareventsplugin.h
236	should be since 5.61 now

Closed by commit R296:811e78ef0ee3: Calendar events: allow plugins to show event details (authored by dvratil). · Explain WhyJul 15 2019, 3:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/calendarevents/calendareventsplugin.h (25 lines)
M			src/calendarevents/calendareventsplugin.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	60065	18de001		Jun 19 2019, 3:37 PM	★	★
Diff 2	60068	18de001	* Fix ABI compatibility	Jun 19 2019, 3:43 PM	★	★
Diff 3	60890	94479bd	Make the change truly API and ABI compatible	Jun 30 2019, 9:48 PM	★	★
Diff 4	61798	1f9fef4	R296:811e78ef0ee346e1d03a49779e0a78c943a87685	Jul 15 2019, 3:19 PM	★	★

Status	Author	Revision
Needs Review	dvratil	D21905 [Digital Clock] Open KOrganizer with event details on click
Needs Review	dvratil	D21902 Calendar: add method to show event details
Accepted	dvratil	D21906 Events plugin: implement the new showEvent() API
Closed	dvratil	D21901 Calendar events: allow plugins to show event details

Calendar events: allow plugins to show event detailsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 61798

src/calendarevents/calendareventsplugin.h

src/calendarevents/calendareventsplugin.cpp

Calendar events: allow plugins to show event details
ClosedPublic
Actions

Revision Contents
Changeset List