Note that this depends on API that will be available first in KDE Frameworks 5.61,
so this should not be merged until Plasma master can depend on KF5 5.61, I'm just
putting it here otherwise I'd lose the patch somewhere :) Alternatively this just
adds a simple function call from QML, so if merged before 5.61 it will only cause
a runtime warning and nothing will happen.
Details
Details
- Reviewers
- None
- Group Reviewers
Plasma
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14441 Build 14459: arc lint + arc unit
Comment Actions
Nothing. Same will happen for example when users click on an event from the Holidays or Astronomical Events calendar plugins as there are no viewers for those events and KOrganizer can only open events provided by the PIM plugin. I would argue that it is safe to assume that when you have the kdepim-addons package installed (which provides the events plugin) and you configured your calendars in Akonadi, that you also have KOrganizer installed :-)
As far as I know, the agenda view is only implemented in the Digital Clock applet.
| applets/digital-clock/package/contents/ui/CalendarView.qml | ||
|---|---|---|
| 196 | Maybe it should only be enabled if there's events to show? | |
Comment Actions
this should not be merged until Plasma master can depend on KF5 5.61
Or you do a check of enabled: typeof monthView.daysModel.showEventDetails === "function"
| applets/digital-clock/package/contents/ui/CalendarView.qml | ||
|---|---|---|
| 196 | This ListItem represents an event, so there's always an event :) | |
Comment Actions
LGTM +1
| applets/digital-clock/package/contents/ui/CalendarView.qml | ||
|---|---|---|
| 194 | I'd use instanceof. Also you can depend on a new KF5 anyway, I wouldn't make it optional. | |
Comment Actions
+1 in general. Probably needs a rebase as I twiddled with a lot of this code recently.
| applets/digital-clock/package/contents/ui/CalendarView.qml | ||
|---|---|---|
| 196 | If there's an otherwise non-obvious click behavior, make the cursor use the Qt.PointingHand cursor using a mouseArea to let the user know that it's clickable. | |