Differential D21692

[DocumentUrlDB] Remove unused 'rename' method
ClosedPublic
Actions

Authored by bruns on Jun 9 2019, 2:22 PM.

Details

Reviewers
ngraham
astippich
poboiko
Group Reviewers
Baloo
Commits
R293:4883ac516d5f: [DocumentUrlDB] Remove unused 'rename' method
Summary

It is not used anywhere, so remove it.

Test Plan

still compiles

Diff Detail

Repository
R293 Baloo
Branch
documenturldb
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12600
Build 12618: arc lint + arc unit
bruns created this revision.Jun 9 2019, 2:22 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 9 2019, 2:22 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Jun 9 2019, 2:22 PM
shubham added a subscriber: shubham.Jun 9 2019, 2:31 PM

Does this function had any use when it was first implemented? Or may it come to use later?

bruns added a comment.Jun 9 2019, 2:38 PM
In D21692#476804, @shubham wrote:

Does this function had any use when it was first implemented? Or may it come to use later?

Its last use was removed with commit 23f9a65c215b068dc87dddf7e81a74415d5cfb10

Problem with it is it only copes with renames, not moves (i.e. changing the parent).

Also see D21694.

ngraham accepted this revision.Jun 10 2019, 4:27 PM

bye bye

This revision is now accepted and ready to land.Jun 10 2019, 4:27 PM
Closed by commit R293:4883ac516d5f: [DocumentUrlDB] Remove unused 'rename' method (authored by bruns). · Explain WhyJun 10 2019, 5:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 59448

View Options

src/engine/documenturldb.h

Loading...
View Options

src/engine/documenturldb.cpp

Loading...