Do not match daemonized dolphin instances
ClosedPublic
Actions

Authored by elvisangelaccio on Jun 8 2019, 11:01 AM.

Details

Reviewers

broulik
ngraham
feverfew

Commits

R318:7df5fc8edb54: Do not match daemonized dolphin instances

Summary

dolphin --daemon does not have the /dolphin/Dolphin_1 dbus path,
because it doesn't have any DolphinMainWindow.

Checking if the QDBusInterface is valid is not enough, we also need to look for dbus errors.

BUG: 408244

Test Plan

Make sure there is a dolphin --deamon process around.
Start another dolphin process.

Diff Detail

Repository

R318 Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio created this revision.Jun 8 2019, 11:01 AM

Restricted Application added a project: Dolphin. · View Herald TranscriptJun 8 2019, 11:01 AM

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

elvisangelaccio requested review of this revision.Jun 8 2019, 11:01 AM

Harbormaster completed remote builds in B12565: Diff 59392.Jun 8 2019, 11:01 AM

elvisangelaccio edited the summary of this revision. (Show Details)Jun 8 2019, 11:03 AM

feverfew accepted this revision.Jun 9 2019, 11:25 AM

This revision is now accepted and ready to land.Jun 9 2019, 11:25 AM

feverfew mentioned this in D21691: Open new instance of Dolphin if no URLs are given.Jun 9 2019, 1:04 PM

Closed by commit R318:7df5fc8edb54: Do not match daemonized dolphin instances (authored by elvisangelaccio). · Explain WhyJun 10 2019, 8:20 PM

This revision was automatically updated to reflect the committed changes.

This does not actually fix https://bugs.kde.org/show_bug.cgi?id=408244:

Open Dolphin
Use that Dolphin window to navigate to an image
Open the image in Gwenview
in Gwenview, go to File → Open Containing Folder

Nothing happens.

@feverfew reopening since this doesn't seem to fix the bug.

This revision is now accepted and ready to land.Jun 13 2019, 4:11 AM

Yeah it seems I should have used CCBUG: instead. D21691 will fix it.

In D21666#477781, @ngraham wrote:

This does not actually fix https://bugs.kde.org/show_bug.cgi?id=408244:

Open Dolphin

Use that Dolphin window to navigate to an image

Open the image in Gwenview

in Gwenview, go to File → Open Containing Folder

Nothing happens.

Actually, I cannot reproduce this issue. At step 4, Dolphin gets raised as expected for me.

In D21666#480524, @elvisangelaccio wrote:

In D21666#477781, @ngraham wrote:

This does not actually fix https://bugs.kde.org/show_bug.cgi?id=408244:

Open Dolphin

Use that Dolphin window to navigate to an image

Open the image in Gwenview

in Gwenview, go to File → Open Containing Folder

Nothing happens.

Actually, I cannot reproduce this issue. At step 4, Dolphin gets raised as expected for me.