Open new instance of Dolphin if no URLs are given

Authored by feverfew on Jun 22 2019, 1:44 PM.

Description

Open new instance of Dolphin if no URLs are given

Summary:
BUG: 408387
BUG: 408244
FIXED-IN: 19.08.0

Currently Dolphin only opens a new instance of itself in the following two scenarios:

  1. No other Dolphin instances ( D21666 deals with not matching daemonized instances) are currently running.
  2. A new instance is explicitly asked for via: dolphin --new-window

A third scenario is needed to fix this bug:

  1. If no URLs are passed in as arguments then open a new instance.

This patch adds this third scenario.

Test Plan:
STEPS TO REPRODUCE

  1. Open Dolphin
  2. Right-click on Dolphin's Task Manager Entry and click "Start New Instance"
  3. A new instance is created.

As my system stuff is not built on master I am unable to replicate the bug (and can't confirm whether this fixes it), hence I'll rely on @ngraham to confirm whether this patch fixes the issue.

Reviewers: ngraham, elvisangelaccio

Reviewed By: ngraham, elvisangelaccio

Subscribers: elvisangelaccio, ngraham, kfm-devel

Tags: Dolphin

Differential Revision: https://phabricator.kde.org/D21691

Details

Committed
ngrahamJun 22 2019, 1:47 PM
Reviewer
ngraham
Differential Revision
D21691: Open new instance of Dolphin if no URLs are given
Parents
R318:ff81ed60cfd7: Fix ECM version comparison
Branches
Unknown
Tags
Unknown