Exclude daemonized processes from Dolphin::attachToExistingInstance()
Needs ReviewPublic

Authored by elvisangelaccio on Dec 24 2019, 5:55 PM.

Details

Reviewers
None
Group Reviewers
Dolphin
Summary

dolphin --daemon does not have the /dolphin/Dolphin_1 dbus path,
because it doesn't have any DolphinMainWindow.

Instead of working around this issue (as we did in D21666 and D25510),
just exclude these processes from the list of dbus instances checked by
Dolphin::attachToExistingInstance().

CCBUG: 408244

Test Plan

Same test plan as in D21666 and D25510

Diff Detail

Repository
R318 Dolphin
Branch
deamon-refactor (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20294
Build 20312: arc lint + arc unit
Restricted Application added a project: Dolphin. · View Herald TranscriptDec 24 2019, 5:55 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Dec 24 2019, 5:55 PM
anthonyfieroni added inline comments.
src/dbusinterface.h
39

Since you can't switch from daemon to non-daemon or vice versa, it should be setAsDaemon (getting no parameters or inject it as constructor parameter)

elvisangelaccio marked an inline comment as done.

Improve API

src/dbusinterface.h
39

Good point