Differential D21691

Open new instance of Dolphin if no URLs are given
ClosedPublic
Actions

Authored by feverfew on Jun 9 2019, 12:59 PM.

Details

Reviewers
ngraham
elvisangelaccio
Commits
R318:d2506ffa6381: Open new instance of Dolphin if no URLs are given
Summary

BUG: 408387
BUG: 408244
FIXED-IN: 19.08.0

Currently Dolphin only opens a new instance of itself in the following two scenarios:

  1. No other Dolphin instances ( D21666 deals with not matching daemonized instances) are currently running.
  2. A new instance is explicitly asked for via: dolphin --new-window

A third scenario is needed to fix this bug:

  1. If no URLs are passed in as arguments then open a new instance.

This patch adds this third scenario.

Test Plan

STEPS TO REPRODUCE

  1. Open Dolphin
  2. Right-click on Dolphin's Task Manager Entry and click "Start New Instance"
  3. A new instance is created.

As my system stuff is not built on master I am unable to replicate the bug (and can't confirm whether this fixes it), hence I'll rely on @ngraham to confirm whether this patch fixes the issue.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
feverfew created this revision.Jun 9 2019, 12:59 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptJun 9 2019, 12:59 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
feverfew requested review of this revision.Jun 9 2019, 12:59 PM
feverfew edited the summary of this revision. (Show Details)Jun 9 2019, 1:04 PM
feverfew edited the test plan for this revision. (Show Details)
feverfew added a reviewer: ngraham.
feverfew added a subscriber: ngraham.
feverfew updated this revision to Diff 59447.Jun 9 2019, 1:05 PM

Fix identation

elvisangelaccio requested changes to this revision.Jun 10 2019, 8:19 PM
elvisangelaccio added a subscriber: elvisangelaccio.
elvisangelaccio added inline comments.
src/global.cpp
75–76

Please move this TODO comment above the if() block, since now it's not about the return false but just the wayland check.

This revision now requires changes to proceed.Jun 10 2019, 8:19 PM
ngraham accepted this revision.Jun 15 2019, 11:08 PM
ngraham edited the summary of this revision. (Show Details)

Looks like this also fixes 408244! Please address @elvisangelaccio's comment, then I think this can land.

feverfew updated this revision to Diff 59986.Jun 17 2019, 11:20 AM
  • Making comment clearer
feverfew marked an inline comment as done.Jun 17 2019, 11:21 AM
ngraham accepted this revision.Jun 17 2019, 12:55 PM
elvisangelaccio accepted this revision.Jun 17 2019, 8:20 PM
This revision is now accepted and ready to land.Jun 17 2019, 8:20 PM
feverfew added a comment.Jun 22 2019, 1:22 PM

@elvisangelaccio note I can't actually commit this as I don't have commit access.

ngraham added a comment.Jun 22 2019, 1:44 PM

Oh right, of course. Landing it now.

Closed by commit R318:d2506ffa6381: Open new instance of Dolphin if no URLs are given (authored by feverfew, committed by ngraham). · Explain WhyJun 22 2019, 1:47 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Jun 22 2019, 1:49 PM

I'm pretty sure GSoC students are supposed to have commit rights. Please apply for a contributor account: https://techbase.kde.org/Contribute/Get_a_Contributor_Account

elvisangelaccio added a comment.Aug 25 2019, 1:36 PM
In D21691#518422, @ngraham wrote:

Sadly this caused https://bugs.kde.org/show_bug.cgi?id=411193.

Crap :/

@ngraham Are you already working on a fix or should I have a look?

ngraham added a comment.Aug 25 2019, 3:11 PM

Go ahead, I'm sure you can fix it in no time.

feverfew added a comment.Aug 25 2019, 4:08 PM
In D21691#518929, @ngraham wrote:

Go ahead, I'm sure you can fix it in no time.

@ngraham @elvisangelaccio have a fix, will be up soon

Revision Contents
Changeset List

PathPackages
Msrc/global.cpp (4 lines)
Msrc/main.cpp (10 lines)

Diff 60350

View Options

src/global.cpp

Loading...
View Options

src/main.cpp

Loading...