Backport Night Color feature to X11
AcceptedPublic

Authored by zzag on Wed, May 22, 5:58 PM.

Details

Reviewers
davidedmundson
romangg
Group Reviewers
KWin
Summary

The color correction manager doesn't make any specific assumptions about
underlying platform, e.g. whether it's x11, etc. The platform just
has to be capable of setting gamma ramps. Given that, there are no any
significant technical blockers for making this feature work on x.

Diff Detail

Repository
R108 KWin
Branch
native-redshift
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 12073
Build 12091: arc lint + arc unit
zzag created this revision.Wed, May 22, 5:58 PM
Restricted Application added a project: KWin. · View Herald TranscriptWed, May 22, 5:58 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Wed, May 22, 5:58 PM
davidedmundson accepted this revision.EditedTue, May 28, 3:46 PM
davidedmundson added a subscriber: davidedmundson.

This was the original plan when redshift was started.
May as well get the extra testing on the code that is there.

This revision is now accepted and ready to land.Tue, May 28, 3:46 PM

Can this land now? The dependent patch has been accepted.

filipf added a subscriber: filipf.Fri, Jun 14, 3:32 PM
GB_2 added a subscriber: GB_2.Sat, Jun 15, 9:59 AM

Ping, would be very nice to have this on X11.

zzag added a comment.Sat, Jun 15, 10:40 AM

If you need this patch in master right now, feel free to land it for me. I got sick with the flu so it might take some time before I do this.

Though I advise you to wait until p-w and p-d patches are accepted.

In D21345#480141, @zzag wrote:

If you need this patch in master right now, feel free to land it for me. I got sick with the flu so it might take some time before I do this.

Though I advise you to wait until p-w and p-d patches are accepted.

Oh no, feel better soon! We can wait a bit, no rush. I'm just eager to announce it. :)

Which other patches should we wait for? I don't see them mentioned in the Description section or listed as dependencies.

GB_2 added a comment.Sun, Jun 16, 8:54 AM

Which other patches should we wait for? I don't see them mentioned in the Description section or listed as dependencies.

D21347 and D21346.

romangg accepted this revision.Sun, Jun 16, 10:46 AM
romangg added a subscriber: romangg.

Next time just add the diffs from p-w / p-d as dependent ones or better create an overview task linking the relevant diffs, so there are none to be missed by reviewers.

I don't like the GammaRamp class being in the AbstractOutput file, but it's not that crucial.