Backport Night Color feature to X11
ClosedPublic
Actions

Authored by zzag on May 22 2019, 5:58 PM.

Details

Reviewers

davidedmundson
romangg

Group Reviewers

KWin

Commits

R108:0d381846f1cc: Backport Night Color feature to X11

Summary

The color correction manager doesn't make any specific assumptions about
underlying platform, e.g. whether it's x11, etc. The platform just
has to be capable of setting gamma ramps. Given that, there are no any
significant technical blockers for making this feature work on x.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zzag created this revision.May 22 2019, 5:58 PM

Restricted Application added a project: KWin. · View Herald TranscriptMay 22 2019, 5:58 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.May 22 2019, 5:58 PM

Harbormaster completed remote builds in B12073: Diff 58493.May 22 2019, 5:58 PM

ngraham added a subscriber: ngraham.May 22 2019, 6:00 PM

zzag added a dependency: D19208: [platforms/x11/standalone] Port to AbstractOutput.May 22 2019, 6:02 PM

This was the original plan when redshift was started.
May as well get the extra testing on the code that is there.

This revision is now accepted and ready to land.May 28 2019, 3:46 PM

Can this land now? The dependent patch has been accepted.

filipf added a subscriber: filipf.Jun 14 2019, 3:32 PM

Ping, would be very nice to have this on X11.

If you need this patch in master right now, feel free to land it for me. I got sick with the flu so it might take some time before I do this.

Though I advise you to wait until p-w and p-d patches are accepted.

In D21345#480141, @zzag wrote:

If you need this patch in master right now, feel free to land it for me. I got sick with the flu so it might take some time before I do this.

Though I advise you to wait until p-w and p-d patches are accepted.

Oh no, feel better soon! We can wait a bit, no rush. I'm just eager to announce it. :)

Which other patches should we wait for? I don't see them mentioned in the Description section or listed as dependencies.

neobrain added a subscriber: neobrain.Jun 16 2019, 8:03 AM

In D21345#480232, @ngraham wrote:

Which other patches should we wait for? I don't see them mentioned in the Description section or listed as dependencies.

D21347 and D21346.

Next time just add the diffs from p-w / p-d as dependent ones or better create an overview task linking the relevant diffs, so there are none to be missed by reviewers.

I don't like the GammaRamp class being in the AbstractOutput file, but it's not that crucial.

ngraham added a dependent revision: D21347: [Night Light KCM] Display the kcm on X11 platform.Jun 16 2019, 2:10 PM

ngraham added a dependent revision: D21346: [libcolorcorrect] Allow color correction on X.

Depends on how you look at it. Gamma ramp is a property of an output, so I see nothing wrong with keeping both together. Am I missing something?

Closed by commit R108:0d381846f1cc: Backport Night Color feature to X11 (authored by zzag). · Explain WhyJun 17 2019, 9:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		abstract_output.h (61 lines)
M		abstract_output.cpp (45 lines)
D	M	colorcorrection/gammaramp.h (53 lines)
M		colorcorrection/manager.cpp (18 lines)
M		plugins/platforms/drm/drm_object_crtc.h (11 lines)
M		plugins/platforms/drm/drm_object_crtc.cpp (13 lines)
M		plugins/platforms/drm/drm_output.h (4 lines)
M		plugins/platforms/drm/drm_output.cpp (6 lines)
M		plugins/platforms/virtual/virtual_output.h (4 lines)
M		plugins/platforms/x11/standalone/x11_output.h (16 lines)
M		plugins/platforms/x11/standalone/x11_output.cpp (27 lines)
M		plugins/platforms/x11/standalone/x11_platform.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	58493	9963ba6		May 22 2019, 5:58 PM	★	★
Diff 2	59978	a39c740	R108:0d381846f1cc8f8f3385483e05fbaba369e560d7	Jun 17 2019, 9:09 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
ca0cd0c8036d	ed89a0c07fc9	9963ba626b18	Vlad Zagorodniy	Backport Night Color feature to X11 (Show More…)	May 17 2019, 10:33 AM

Status	Author	Revision
Closed	zzag	D21347 [Night Light KCM] Display the kcm on X11 platform
Closed	zzag	D21346 [libcolorcorrect] Allow color correction on X
Closed	zzag	D21345 Backport Night Color feature to X11
Closed	romangg	D19208 [platforms/x11/standalone] Port to AbstractOutput