Differential D20855

[TagsFileItemAction] Fix bad truncation of tag name
ClosedPublic
Actions

Authored by bruns on Apr 26 2019, 10:35 PM.

Details

Reviewers
nicolasfella
ngraham
elvisangelaccio
Group Reviewers
Baloo
Dolphin
Commits
R824:eb084799ad5b: [TagsFileItemAction] Fix bad truncation of tag name
R824:0bce0c4eda2b: [TagsFileItemAction] Fix bad truncation of tag name
Summary

Instead of reconstructing the tag name from the QAction text, just
capture the tag name. The action is not required in the capture, as the
checked state is emitted as a signal parameter.

BUG: 405777

Test Plan

Add tag via context menu

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 26 2019, 10:35 PM
Restricted Application added a project: Baloo. · View Herald TranscriptApr 26 2019, 10:35 PM
bruns requested review of this revision.Apr 26 2019, 10:35 PM
This revision is now accepted and ready to land.Apr 27 2019, 10:15 PM
Closed by commit R824:eb084799ad5b: [TagsFileItemAction] Fix bad truncation of tag name (authored by bruns). · Explain WhyApr 28 2019, 12:02 AM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio added a comment.Apr 28 2019, 10:52 AM

Can you please push this fix to the Applications/19.04 branch too?

Revision Contents
Changeset List

Diff 57118

View Options

src/tagsfileitemactionplugin/tagsfileitemaction.cpp

Loading...