Differential D20865

[TagsFileItemAction] Avoid readding an existing tag via "New tag..."
ClosedPublic
Actions

Authored by bruns on Apr 27 2019, 12:27 PM.

Details

Reviewers
nicolasfella
ngraham
elvisangelaccio
Group Reviewers
Baloo
Dolphin
Commits
R824:2b62b0b0c144: [TagsFileItemAction] Avoid readding an existing tag via "New tag..."
R824:80000b7414da: [TagsFileItemAction] Avoid readding an existing tag via "New tag..."
Summary

The value from the input dialog may be identical to an already set tag.
Avoid writing duplicate tags.

Test Plan
  1. Add a tag "Foo" to a file
  2. Add "Foo" a second time via "New tag..."
  3. getfattr -d <file> should show "Foo" only once

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns requested review of this revision.Apr 27 2019, 12:27 PM
bruns created this revision.
nicolasfella accepted this revision.Apr 27 2019, 10:19 PM
This revision is now accepted and ready to land.Apr 27 2019, 10:19 PM
Closed by commit R824:2b62b0b0c144: [TagsFileItemAction] Avoid readding an existing tag via "New tag..." (authored by bruns). · Explain WhyApr 28 2019, 12:06 AM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio added a comment.Apr 28 2019, 10:53 AM

Can you please push this fix to the Applications/19.04 branch too?

bruns added a comment.Apr 28 2019, 11:24 AM
In D20865#457401, @elvisangelaccio wrote:

Can you please push this fix to the Applications/19.04 branch too?

Done, dito for D20855, D20858

Revision Contents
Changeset List

Diff 57120

View Options

src/tagsfileitemactionplugin/tagsfileitemaction.cpp

Loading...