Pass va_list as such, instead of passing to variadic function

Authored by luc4 on Mar 30 2019, 1:05 AM.



Logs from krdc appear corrupted for me. This patch should fix values in the logs.

Diff Detail

Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
luc4 requested review of this revision.Mar 30 2019, 1:05 AM
luc4 created this revision.
uwolfer resigned from this revision.Mar 30 2019, 10:51 AM

I cannot comment on this - code looks nice, but I do not know the 'va_list' thing. Can somebody else who know this review please?

luc4 added a comment.Mar 30 2019, 10:54 AM

Should I add someone else as reviewer (sorry, I'm not an experience KDE dev)?

kossebau resigned from this revision.Apr 2 2019, 10:42 AM

Same for me, sadly, not dealt enough with va_list to properly comment on correctness.

aacid accepted this revision.Apr 2 2019, 9:02 PM
aacid added a subscriber: aacid.

Makes sense, we're already unboxing the va_list in outputHandlerStatic

This revision is now accepted and ready to land.Apr 2 2019, 9:02 PM
This revision was automatically updated to reflect the committed changes.