Pass va_list as such, instead of passing to variadic function
ClosedPublic
Actions

Authored by luc4 on Mar 30 2019, 1:05 AM.

Details

Reviewers

Group Reviewers

KDE Applications

Commits

Summary

Logs from krdc appear corrupted for me. This patch should fix values in the logs.

Repository

R436 KRDC

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

luc4 requested review of this revision.Mar 30 2019, 1:05 AM

luc4 created this revision.

I cannot comment on this - code looks nice, but I do not know the 'va_list' thing. Can somebody else who know this review please?

Should I add someone else as reviewer (sorry, I'm not an experience KDE dev)?

Same for me, sadly, not dealt enough with va_list to properly comment on correctness.

Makes sense, we're already unboxing the va_list in outputHandlerStatic

This revision is now accepted and ready to land.Apr 2 2019, 9:02 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			vnc/vncclientthread.h (2 lines)
M			vnc/vncclientthread.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	55048			Mar 30 2019, 12:55 AM	★	★
Diff 2	55315	3f31a41	R436:73a68fe2ef707bcf1c27c66e144ab9cc2085a16b	Apr 2 2019, 9:03 PM	★	★