Add High DPI support
ClosedPublic

Authored by volkov on Mar 20 2019, 4:38 PM.

Diff Detail

Repository
R410 KPatience
Branch
Applications/19.04
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9934
Build 9952: arc lint + arc unit
volkov created this revision.Mar 20 2019, 4:38 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptMar 20 2019, 4:38 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
volkov requested review of this revision.Mar 20 2019, 4:38 PM

@davidedmundson you know stuff about hidpi, can you give this a look?

apol added a subscriber: apol.Mar 20 2019, 9:39 PM

Just gave it a try, it's super tiny.

This is strange. I can't reproduce it.
Could you provide more information?

  • Wayland or X11
  • version of Qt
  • env | grep QT
libkcardgame/kcardthemewidget.cpp
85 ↗(On Diff #54429)

this image doesn't have the DPR set

104 ↗(On Diff #54429)

Any patch that has code to render bigger is normally a bad sign.

We should only be resizing the backing stores and having the DPR set on that backing store.

The rest will implicitly "just work".

206 ↗(On Diff #54429)

why?

The image coming in should have a DPR set.

Also tiny for me.

  • Wayland or X11

X11

  • version of Qt

5.12.2

  • env | grep QT

QT_AUTO_SCREEN_SCALE_FACTOR=0
QT_PLUGIN_PATH=/usr/host/lib/qt5/plugins
QT_SCREEN_SCALE_FACTORS=HDMI-1=1;HDMI-2=1;DP-1=1;HDMI-3=1;

Fix for tiny cards: D20061

meven added a subscriber: meven.Oct 28 2019, 10:11 AM

This needs to be rebased and (with D20061 now in master), but worked like a charm on Wayland HDIPI 2x scale factor and in X11 no scale.

Why rebase? I can cherry-pick this change to master without conflicts.

Do you mean that it doesn't work on X11?

Why rebase? I can cherry-pick this change to master without conflicts.

In this case one commit, rebase is equivalent to cherry-pick.

Do you mean that it doesn't work on X11?

I mean it works.

meven accepted this revision.Nov 11 2019, 11:04 AM

LGTM

This revision is now accepted and ready to land.Nov 11 2019, 11:04 AM
volkov closed this revision.Nov 11 2019, 1:42 PM

Hmmm, unfortunately arc created a needless merge commit :(