Launch jumplist actions via KGlobalAccel
ClosedPublic

Authored by mart on Jul 6 2016, 3:06 PM.

Details

Summary

make the kglobalaccel daemon capable of launching applications
from their desktop file or to launch a particular action defined by
their jumplist action entries in their desktop file

In order to be enabled by default, the application would have
to install a copy of its desktop file (which has extra X-KDE-Shortcuts entry)
in prefix/share/kglobalaccel

from the kcm side the user will be able to add shortcuts to launch any
app that has a desktop file (or any action defined by it) making
possible to drop khotkeys and its kcm

Diff Detail

Branch
arcpatch-D2103
Lint
No Linters Available
Unit
No Unit Test Coverage
mart updated this revision to Diff 4984.Jul 6 2016, 3:06 PM
mart retitled this revision from to Launch jumplist actions via KGlobalAccel.
mart edited the test plan for this revision. (Show Details)
mart updated this object.
mart updated this revision to Diff 5204.Jul 15 2016, 10:28 AM
  • remove the legacy Friendly Name group
  • support addition of launchers at runtime
graesslin edited edge metadata.Aug 3 2016, 10:55 AM

Overall looks good to me. I would love to see an autotest for it, but are also lacking ideas on how to do that...

src/runtime/component.cpp
177

nitpick: unrelated change

386–400

please use kdelibs coding style for new code (even if the remaining code is in ugly-style ;-) )

397

QLatin1String

src/runtime/component.h
122

please add documentation

src/runtime/globalshortcutsregistry.cpp
282

QLatin1String

319

QStringLiteral

333

QStringLiteral

src/runtime/kglobalacceld.cpp
151

QLatin1String

156

QStringLiteral

src/runtime/kserviceactioncomponent.cpp
108

moc include before end of namespace? Is that intended?

mart updated this revision to Diff 5654.Aug 3 2016, 11:47 AM
mart edited edge metadata.
  • minor fixes
graesslin accepted this revision.Aug 4 2016, 12:49 PM
graesslin edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2016, 12:49 PM
mart closed this revision.Aug 4 2016, 12:58 PM