KFileWidget In saving single file mode an enter/return press on the…
bea5b68142e4
Actions

Authored by meven on Mar 28 2019, 9:31 PM.

Description

KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

Summary:
Draw inspiration from inspiration from https://phabricator.kde.org/D12538 for reference.

The issue at hand:

the KDirOperator did not signal when it received an enter/return event when it should.
This prevents expected behavior

BUG: 385189
FIXED-IN: 5.57

Test Plan:
1 compile kio and its test kfilewidgettest_saving_gui.cpp
2 launch kfilewidgettest_saving_gui
4 click on an place on the left
5 Hit enter
6 The dialog closes, the filename selected is printed out in the terminal

Reviewers: Frameworks, Dolphin, ngraham, dfaure

Reviewed By: Dolphin, ngraham, dfaure

Subscribers: ngraham, kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D19824

Details

Committed

meven

Mar 28 2019, 9:34 PM

Reviewer

Dolphin

Differential Revision

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

Parents

R241:ed158497a322: [KDynamicJobTracker] Use generated DBus interface

Branches

Unknown

Tags

Unknown

meven committed R241:bea5b68142e4: KFileWidget In saving single file mode an enter/return press on the… (authored by meven).Mar 28 2019, 9:34 PM

Changes (6)

				Path	Packages
	M			src/filewidgets/kdiroperator.cpp
	M			src/filewidgets/kdiroperator.h
	M			src/filewidgets/kfilewidget.cpp
	M			src/filewidgets/kfilewidget.h
	M			tests/CMakeLists.txt
	P			tests/kfilewidgettest_saving_gui.cpp Copied from tests/kfilewidgettest_gui.cpp