Differential D19268

Let tests use the baloo_filemetadata_temp_extractor from the build dir
ClosedPublic
Actions

Authored by bruns on Feb 24 2019, 12:32 AM.

Details

Reviewers
ngraham
astippich
poboiko
Group Reviewers
Frameworks
Baloo
Commits
R824:0c782040b212: Let tests use the baloo_filemetadata_temp_extractor from the build dir
Summary

Without adding the build directory to the PATH,
QStandardPaths::findExecutable will return the temp extractor from the
system, i.e. testing the wrong executable.

Test Plan

ctest

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Feb 24 2019, 12:32 AM
Restricted Application added a project: Baloo. · View Herald TranscriptFeb 24 2019, 12:32 AM
bruns requested review of this revision.Feb 24 2019, 12:32 AM
ngraham accepted this revision.Feb 24 2019, 4:12 PM

Great catch!

This revision is now accepted and ready to land.Feb 24 2019, 4:12 PM
Closed by commit R824:0c782040b212: Let tests use the baloo_filemetadata_temp_extractor from the build dir (authored by bruns). · Explain WhyFeb 24 2019, 4:23 PM
This revision was automatically updated to reflect the committed changes.
bruns added a subscriber: Windows.Mar 1 2019, 7:42 PM

Actually, it is quite happy to report it can not execute the binary in build/bin/, which is IMHO an error in the CI setup.

I don't have windows, so someone else has to look into this.

bcooksley added a subscriber: bcooksley.Mar 1 2019, 7:47 PM

Sorry, I don't see where it's complaining about not finding the right binary?
(Not finding Dr Konqi is expected, given that it's part of Plasma and not a dependency of baloo-widgets)

bruns added a comment.Mar 1 2019, 7:53 PM
In D19268#422709, @bcooksley wrote:

Sorry, I don't see where it's complaining about not finding the right binary?
(Not finding Dr Konqi is expected, given that it's part of Plasma and not a dependency of baloo-widgets)

Its complaining about not being able to execute the right binary, exception code 0xc0000315.

bcooksley added a comment.Mar 1 2019, 9:59 PM

Given that Baloo Widgets isn't the only project showing that class of failure, it's more likely to be a case of ECM getting something wrong.
(The CI system doesn't do anything special when it comes to this part of the execution)

Revision Contents
Changeset List

PathPackages
Mautotests/CMakeLists.txt (11 lines)

Diff 52450

View Options

autotests/CMakeLists.txt

Loading...