Differential D20960

[Extractor] Move property conversion from external process to calling job
ClosedPublic
Actions

Authored by bruns on May 2 2019, 11:26 AM.

Details

Reviewers

astippich
ngraham

Group Reviewers

Baloo

Commits

R824:af637f7579b4: [Extractor] Move property conversion from external process to calling job

Summary

Using integer keys is more compact, and allows to remove the
KFileMetaData::PropertyInfo code from the temporary extractor.

Doing the conversion from integer to QString keys after serialization also
allows shared string data, as it uses the instances from PropertyInfo::name()
instead of inherently non-shared QStrings from deserialization.

Depends on D20956
Depends on D20738

Test Plan

ctest

Diff Detail

Repository

R824 Baloo Widgets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bruns created this revision.May 2 2019, 11:26 AM

Restricted Application added a project: Baloo. · View Herald TranscriptMay 2 2019, 11:26 AM

bruns requested review of this revision.May 2 2019, 11:26 AM

Harbormaster completed remote builds in B11440: Diff 57374.May 2 2019, 11:26 AM

bruns edited the summary of this revision. (Show Details)May 2 2019, 11:27 AM

bruns added a dependency: D20956: [UserMetaData] Consolidate UserMetaData conversion to common implementation.

bruns mentioned this in D20738: Move map conversion to common file.May 2 2019, 11:36 AM

rebase on D20738

Harbormaster completed remote builds in B11473: Diff 57427.May 3 2019, 12:21 AM

bruns edited the summary of this revision. (Show Details)May 3 2019, 12:22 AM

bruns added a dependency: D20738: Move map conversion to common file.

FileMetaDataDateDisplayTest first spew a lot of warnings (but eventually passed?). D19268 missed the DateDisplayTest

This revision is now accepted and ready to land.May 3 2019, 5:50 AM

Closed by commit R824:af637f7579b4: [Extractor] Move property conversion from external process to calling job (authored by bruns). · Explain WhyMay 3 2019, 11:48 AM

This revision was automatically updated to reflect the committed changes.

In D20960#460024, @astippich wrote:

FileMetaDataDateDisplayTest first spew a lot of warnings (but eventually passed?). D19268 missed the DateDisplayTest

Good catch, I have added the test and pushed the change.

Revision Contents
Changeset List

		Path
M		autotests/CMakeLists.txt (1 line)
M		autotests/extractortest.cpp (13 lines)
M		src/extractor.cpp (8 lines)
A	M	src/extractorutil_p.h (41 lines)
M		src/indexeddataretriever.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	57374	030d27a		May 2 2019, 11:26 AM	★	★
Diff 2	57427	eb83b69	rebase on D20738	May 3 2019, 12:21 AM	★	★
Diff 3	57454	ecf7df9	R824:af637f7579b44acf329dd12430c806d23fa6525a	May 3 2019, 11:47 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
052a53e6de51	c6be6b8bdd6b	eb83b6963c2b	Stefan Brüns	[Extractor] Move property conversion from external process to calling job (Show More…)	May 2 2019, 1:52 AM

Status	Author	Revision
Closed	astippich	D20740 Add a test for multiple properties
Closed	astippich	D20739 Handle multiple entries in map
Closed	bruns	D20960 [Extractor] Move property conversion from external process to calling job
Closed	bruns	D20956 [UserMetaData] Consolidate UserMetaData conversion to common implementation
Closed	astippich	D20738 Move map conversion to common file