Differential D19202

Skip base64 encoding of QDataStream, avoid temporary QByteArray
ClosedPublic
Actions

Authored by bruns on Feb 21 2019, 3:04 PM.

Details

Reviewers
astippich
ngraham
Group Reviewers
Frameworks
Baloo
Commits
R824:a2ebf9dd3b51: Skip base64 encoding of QDataStream, avoid temporary QByteArray
Summary

There is no need to do any Base64 encoding of the data. Also avoid
streaming the data to an intermediate QByteArray, but directly stream
to stdout.

Test Plan

PATH=pwd/bin/:$PATH ctest

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Feb 21 2019, 3:04 PM
Restricted Application added a project: Baloo. · View Herald TranscriptFeb 21 2019, 3:04 PM
bruns requested review of this revision.Feb 21 2019, 3:04 PM
astippich added a comment.Feb 23 2019, 3:47 PM

This causes at least one failure in all tests except filemetadatadisplaytest here? the properties are not properly retrieved somehow
and the warning
"Trying to construct an instance of an invalid type, type id: 21123393"
is given.

bruns added a comment.Feb 23 2019, 5:38 PM
In D19202#418088, @astippich wrote:

This causes at least one failure in all tests except filemetadatadisplaytest here? the properties are not properly retrieved somehow
and the warning
"Trying to construct an instance of an invalid type, type id: 21123393"
is given.

If you don't add the build directory to your path, it uses the extractor from your installation.

bruns added a dependency: D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir.Feb 24 2019, 12:33 AM

Does not really depend on D19268, but avoids errors due to a incomplete PATH

ngraham accepted this revision.Feb 24 2019, 4:20 PM
This revision is now accepted and ready to land.Feb 24 2019, 4:20 PM
Closed by commit R824:a2ebf9dd3b51: Skip base64 encoding of QDataStream, avoid temporary QByteArray (authored by bruns). · Explain WhyFeb 24 2019, 4:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 52451

View Options

autotests/extractortest.cpp

Loading...
View Options

src/extractor.cpp

Loading...
View Options

src/indexeddataretriever.cpp

Loading...