used by:
- knotification
- (possibly also knotifyconfig at some point)
- plasma-pa
- kmix
krop |
used by:
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Good point, I've also noticed that (all?) our finders now also create an IMPORTED target. Should we maybe add that too? If so I guess Canberra::Canberra would be the preferred target name?
Yes, imported targets are the future/present :)
Canberra::Canberra sounds good to me as target name
+1
You may also add a set_package_properties() call. see eg: D18947. This way, the users only have to use the VERSION and TYPE in their CMakeLists.txt.
find-modules/FindCanberra.cmake | ||
---|---|---|
10–17 | The variables shall be renamed "Canberra_XXX". If needed, the uppercase ones shall be added at the bottom of the file with a comment to indicate they only exist for compatibility. | |
49–50 | Use the 'QUIET' keyword for both lines | |
54 | PC_CANBERRA_LIBDIR isn't needed | |
59 | Same thing for PC_CANBERRA_INCLUDEDIR |
Thanks! just a little thing to fix before pushing
find-modules/FindCanberra.cmake | ||
---|---|---|
76 | Also add FOUND_VAR Canberra_FOUND The default for CMake 2.8.12 which ECM requires is '<UPPERCASED_NAME>_FOUND'. |