Bring FindUDev.cmake up to ECM standards
ClosedPublic
Actions

Authored by vkrause on Feb 12 2019, 10:59 AM.

Details

Reviewers

krop
apol

Group Reviewers

Build System

Commits

R245:7464b55f0638: Bring FindUDev.cmake up to ECM standards

Summary

This prepares it to be upstreamed to ECM, as it's also needed by KWin
and qtbase.

Repository

R245 Solid

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

vkrause requested review of this revision.Feb 12 2019, 10:59 AM

Looks good to me, comments in D18943 still apply but let's not block.

This revision is now accepted and ready to land.Feb 12 2019, 11:13 AM

aacid added inline comments.

cmake/FindUDev.cmake
75	Do we need a INTERFACE_COMPILER_DEFINITIONS "${UDev_DEFINITIONS}" just in case that udev adds some definitions at some point?

Add IMPORTED_COMPILE_DEFINITIONS property.

cmake/FindUDev.cmake
10	UDev_INCLUDE_DIRS
13	UDev_LIBRARIES

Fix typos.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (7 lines)
M			KF5SolidConfig.cmake.in (2 lines)
M			cmake/FindUDev.cmake (68 lines)
M			src/solid/devices/CMakeLists.txt (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	51485	92d7d26		Feb 12 2019, 10:59 AM	★	★
Diff 2	51845	92d7d26	Add IMPORTED_COMPILE_DEFINITIONS property.	Feb 16 2019, 10:29 AM	★	★
Diff 3	51848	92d7d26	Fix typos.	Feb 16 2019, 11:26 AM	★	★
Diff 4	51853	92d7d26	R245:7464b55f06389167d1b41b80885eb7d05656099e	Feb 16 2019, 12:46 PM	★	★