Adds battery icons at 16, 22 and 32 px. Includes symlinks for symbolic icons and standard icon names for compatibility with 3rd parties. Adds status/32 to index.theme. Changes status/22 and status/22@2x from Scalable to Fixed. Requested by @hein for drone control app.
Details
Diff Detail
- Repository
- R266 Breeze Icons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I like it!
Would you consider moving the green charging to either the filled-in or the white part where the symbol is currently above the line where the filled-in part ends?
So I guess this means some duplication between the Breeze icon theme and the Breeze Plasma theme for a while, right?
If we get this in before Frameworks 5.58, then Plasma 5.16 can depend on having them in the Breeze icon theme and maybe we can port the code to use these as icons from the icon theme rather than SVGs from the Plasma theme and then delete them from the Plasma theme. Baby steps...
Not 100%. I need to make a device icon for an uninterruptible power supply. I suppose I could add that to this diff, but it's not immediately necessary either. I'll get it done before 5.57 is tagged.
If we get this in before Frameworks 5.58, then Plasma 5.16 can depend on having them in the Breeze icon theme and maybe we can port the code to use these as icons from the icon theme rather than SVGs from the Plasma theme and then delete them from the Plasma theme. Baby steps...
That's the idea, but moving Plasma theme icons into Breeze icons only has the potential to make the issues with color vs monochrome worse. I don't have a problem with continuing for now since it's highly unlikely that any of these icons will be used where we would want a color icon to go even though some of these are 32px.
maybe we can port the code to use these as icons from the icon theme rather than SVGs from the Plasma theme and then delete them from the Plasma theme
And in the process break all third party Plasma themes?
Sure but in the style of a Plasma battery.svgz, so if we change the BatteryIcon to use icon theme instead of Plasma theme icons (which none of the other tray icons do, btw) we'll effectively break third party themes.
Does a plasmoid need to be told to get the icons from the Plasma theme? Or will it fetch the icon from the icon theme if it does not exist in the plasma theme?
The battery icon is composited of multiple SVG items layered ontop of each other, it doesn't just load a single icon.
I'm in favor of adding proper battery icons to the Breeze iconset, definitely need "battery", "battery-caution", "battery-low" icons (from the freedesktop icon spec) but we cannot remove them from the Plasma theme.
Fair enough. Fun fact: there is no desktop environment that uses battery-caution and battery-low in the manner defined by the fd.o icon naming spec.
Ideally I would like to move all icons out of Plasma themes, because these themes are not 100% self-contained and often use icons from the icon theme anyway, and users get confused as to why changing their icon theme only changes some (but not all) Plasma icons. And it makes life a bit harder for us to maintain icons in two different places.
However that is indeed another discussion and this looks good to me the way it is.
The do a proper proposal (I bet you already have a task about that) instead of just slipping things in one by one in unrelated reviews
Not trying to slip anything in (this patch doesn't and can't touch plasma-framework, after all), just mentioning it. :)
The proposal is in T10046: Improve the colors, color consistency and colorscheme compatibility of Breeze.
This is the configuration for status/32:
[status/32] Size=32 Context=Status Type=Fixed
This currently prevents the 32px icons in this patch from being used:
[status/22] Size=22 Context=Status Type=Scalable MinSize=22 MaxSize=32
Would changing status/22 to Fixed cause a problem? It doesn't appear to cause any real issue when I look at the change through Cuttlefish.
Run dolphin with QT_SCALE_FACTOR=2 in the environment and see if the Places panel icons are still monochrome.
Places panel icons aren't status icons. I tried the same environment variable on Cuttlefish and it still looks ok.