Found better categories for GHNS v3: looks like only Aurorae is supported?
Also refresh the themes when you close the GHNS window, in case something was downloaded.
Details
Details
- Reviewers
leinir graesslin davidedmundson - Group Reviewers
KWin - Commits
- R108:31dcf51c8843: [kcmkwin/kwindecoration] Fix Get Hot New Stuff
Open GHNS, download new theme, close GHNS -> new theme visible
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| kcmkwin/kwindecoration/window-decorations.knsrc | ||
|---|---|---|
| 65 | Are there other kinds of decorations that should be supported? If so, I need to add a new .knsrc and this will be only for aurorae | |
Comment Actions
| kcmkwin/kwindecoration/window-decorations.knsrc | ||
|---|---|---|
| 65 | Since KWin itself only supports Aurorae, you don't need to add others. Third-party engines are supposed to ship their own .knsrc file, see e.g. https://cgit.kde.org/smaragd.git/tree/src/smaragd.knsrc KWins decoration UI works fine with multiple files (at least it did; hopefully the rewrite didn't break it :) | |
Comment Actions
Lovely, works for me FWIW.
Now we need a delete button on the delegates like all the other ones have, so you don't back to to back into the GHNS to remove a theme.
Comment Actions
Perfect.
Now we need a delete button on the delegates like all the other ones have, so you don't back to to back into the GHNS to remove a theme.
Something for another review :) I was also thinking about doing that.
| kcmkwin/kwindecoration/window-decorations.knsrc | ||
|---|---|---|
| 65 | Excellent. The new KCM UI should be making the same plugin search as before. I'll try Smaragd to test. | |
| kcmkwin/kwindecoration/window-decorations.knsrc | ||
|---|---|---|
| 65 | Smaragd indeed shows up in the list. And gets updated when you install a new theme for it (and then refresh KWin by e.g. opening and closing GHNS). | |
Comment Actions
LGTM, yup! :) Sort of two things in one, there, but both good changes, so let's roll with it :)