[kcmkwin/kwindecoration] Fix Get Hot New Stuff
ClosedPublic

Authored by vpilo on Mon, Feb 11, 10:33 PM.

Details

Summary

Found better categories for GHNS v3: looks like only Aurorae is supported?

Also refresh the themes when you close the GHNS window, in case something was downloaded.

Test Plan

Open GHNS, download new theme, close GHNS -> new theme visible

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vpilo created this revision.Mon, Feb 11, 10:33 PM
Restricted Application added a project: KWin. · View Herald TranscriptMon, Feb 11, 10:33 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
vpilo requested review of this revision.Mon, Feb 11, 10:33 PM
vpilo added inline comments.
kcmkwin/kwindecoration/window-decorations.knsrc
65

Are there other kinds of decorations that should be supported? If so, I need to add a new .knsrc and this will be only for aurorae

cfeck added a subscriber: cfeck.Tue, Feb 12, 1:30 AM
kcmkwin/kwindecoration/window-decorations.knsrc
65

Since KWin itself only supports Aurorae, you don't need to add others. Third-party engines are supposed to ship their own .knsrc file, see e.g. https://cgit.kde.org/smaragd.git/tree/src/smaragd.knsrc

KWins decoration UI works fine with multiple files (at least it did; hopefully the rewrite didn't break it :)

Lovely, works for me FWIW.

Now we need a delete button on the delegates like all the other ones have, so you don't back to to back into the GHNS to remove a theme.

vpilo marked an inline comment as done.Tue, Feb 12, 8:38 AM

Lovely, works for me FWIW.

Perfect.

Now we need a delete button on the delegates like all the other ones have, so you don't back to to back into the GHNS to remove a theme.

Something for another review :) I was also thinking about doing that.

kcmkwin/kwindecoration/window-decorations.knsrc
65

Excellent. The new KCM UI should be making the same plugin search as before. I'll try Smaragd to test.

vpilo marked an inline comment as done.Tue, Feb 12, 12:15 PM
vpilo added inline comments.
kcmkwin/kwindecoration/window-decorations.knsrc
65

Smaragd indeed shows up in the list. And gets updated when you install a new theme for it (and then refresh KWin by e.g. opening and closing GHNS).

davidedmundson accepted this revision.Tue, Feb 12, 1:15 PM
This revision is now accepted and ready to land.Tue, Feb 12, 1:15 PM
leinir accepted this revision.Tue, Feb 12, 1:17 PM

LGTM, yup! :) Sort of two things in one, there, but both good changes, so let's roll with it :)

This revision was automatically updated to reflect the committed changes.