[sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative
ClosedPublic

Authored by rooty on Sun, Feb 10, 8:52 AM.

Details

Summary

This patch adds the buttons Suspend, Restart, and Shut Down to the username prompt screen that appears once the Type User button is clicked so the user is able to suspend/restart/shut down from that screen without having to return to the initial login screen.
It also replaces the "Back" button with "List Users" (and an appropriate icon) on account of the latter being a more accurate description of what the screen goes back to once the button is clicked (and in case of future improvements, enables it to become a standalone login screen as well).

Test Plan

Before:


After:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rooty created this revision.Sun, Feb 10, 8:52 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Feb 10, 8:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Sun, Feb 10, 8:52 AM
rooty edited the test plan for this revision. (Show Details)Sun, Feb 10, 8:53 AM
rooty added reviewers: VDG, Plasma.
rooty edited the summary of this revision. (Show Details)
rooty edited the summary of this revision. (Show Details)Sun, Feb 10, 8:58 AM
rooty edited the summary of this revision. (Show Details)
rooty edited the summary of this revision. (Show Details)
rooty edited the summary of this revision. (Show Details)Sun, Feb 10, 9:01 AM
rooty edited the summary of this revision. (Show Details)Sun, Feb 10, 10:01 AM
filipf accepted this revision.Sun, Feb 10, 1:51 PM
filipf added a subscriber: filipf.

+1

This revision is now accepted and ready to land.Sun, Feb 10, 1:51 PM

If we do this, then "List Users" and "Type User" will both be using the same icons. Feels like we should use more appropriate ones that visually suggest what the page it will take you to actually looks like.

rooty added a comment.Sun, Feb 10, 3:13 PM

If we do this, then "List Users" and "Type User" will both be using the same icons. Feels like we should use more appropriate ones that visually suggest what the page it will take you to actually looks like.

That makes sense
An icon of a list and an icon of a prompt?

Yeah, like a line-art representation of the horizontal switcher, and a line-art representation of a username/password prompt.

rooty added a comment.EditedMon, Feb 11, 2:06 AM

Yeah, like a line-art representation of the horizontal switcher, and a line-art representation of a username/password prompt.

How's this for the switcher?

Not too sure about the design but I managed to... make it symmetrical (sorry about all the edits)

rooty added a comment.EditedMon, Feb 11, 5:54 AM

I couldn't really sleep last night so I made this one too


Any and all input regarding the design of the icons is appreciated :D

+1 on the concept. Adding here my comments in the VDG channel regarding the icons:

  • For the "Type User" icon, I liked the one that was dots/asterisks with an I-Beam cursor at the end.
  • For the "List Users" icon, my recommendation is a new icons that has three people: two in the back, and a third in front of them, but a bit bigger.

From my POV, +1 too.

sddm-theme/Main.qml
373–374

should this also have

visible: !inputPanel.keyboardActive

?

From my POV, +1 too.

Good point! I'll just add it

rooty updated this revision to Diff 51667.Thu, Feb 14, 12:44 PM

Add visible: !inputPanel.keyboardActive

rooty marked an inline comment as done.Thu, Feb 14, 12:44 PM
davidedmundson accepted this revision.Thu, Feb 14, 12:54 PM
rooty added a comment.EditedThu, Feb 14, 12:56 PM

Thanks for accepting the patch!
Should I land this and deal with the icons in another diff? Because this is in "plasma-workspace" and the icons are in "plasma-framework"?

Then again, I might have to change the code here (the new icons have different labels).
This is what I've got so far:


ngraham accepted this revision.Thu, Feb 14, 2:44 PM

Land this now, then let's do the icons in another patch.

Thanks for accepting the patch!
Should I land this and deal with the icons in another diff? Because this is in "plasma-workspace" and the icons are in "plasma-framework"?

Then again, I might have to change the code here (the new icons have different labels).
This is what I've got so far:

For this image with the dots and type, shouldn't that be centered and not touch the edge of the circle?

This revision was automatically updated to reflect the committed changes.
rooty added a comment.Thu, Feb 14, 8:35 PM

Hey guys so I opened up another diff to deal with the icons specifically: D19020

For this image with the dots and type, shouldn't that be centered and not touch the edge of the circle?

That works too, but the idea here was to make it seem like it has more depth. Not sure though. Still open to any and all suggestions....

Hey guys so I opened up another diff to deal with the icons specifically: D19020

For this image with the dots and type, shouldn't that be centered and not touch the edge of the circle?

That works too, but the idea here was to make it seem like it has more depth. Not sure though. Still open to any and all suggestions....

I would suggest to keep elements centered just to follow the general logic of the rest of the icons.