Press Ctrl + Tab and a session switcher will appear showing every
tab that you have, you can navigate with buttons, close via
focus out, esq key or selecting an index.
Details
Details
- Reviewers
hindenburg - Group Reviewers
Konsole
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Branch
- altTabBehavior
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6906 Build 6924: arc lint + arc unit
| src/ViewManager.cpp | ||
|---|---|---|
| 295 | What you think about change the previous context hotkey to shift instead of meta. Some well known software like browsers use this shortcut and I think it will be more natural and intuitive. | |
Comment Actions
What about merging this with the lastUsedView feature ?
Pressing Ctrl-Tab would open show the switcher ordered according to tabHistory. The tabs would be switched "live" while iterating through the list. The switcher would close when releasing the Ctrl key.
What do you think ?
Comment Actions
Actually, I belive that if I do this change, it will conflict with our
other branch. *maybe* this should stay as is for now, untill we merge
the splits rewrite.
Comment Actions
Agreed, the code around the lastUsedView has changed quite a bit in the terminatorStyleTabs branch, let's not duplicate the work. Except if terminatorStyleTabs is not ready for 19.04 ...
Comment Actions
I thought this had to wait until the split tabs code went in - if not I can review now
Comment Actions
No; both are unrelated
Em qua, 30 de jan de 2019 às 14:30, Kurt Hindenburg <
noreply@phabricator.kde.org> escreveu:
hindenburg added a comment. View Revision
https://phabricator.kde.org/D18154I thought this had to wait until the split tabs code went in - if not I
can review now*REPOSITORY*
R319 Konsole*REVISION DETAIL*
https://phabricator.kde.org/D18154*To: *tcanabrava, hindenburg, Konsole
*Cc: *ngraham, thsurrel, lucasew, mart, konsole-devel, maciejn,
maximilianocuria, hindenburg
Comment Actions
A quick look running and I'm not a big fan: 1) It doesn't handle split views (assume that after the split tab changes go in, this could be fix), 2) if only tab, don't show anything, 3) releasing the Ctrl+Tab should close popup and go to selected 4) I'm tempted to have a way to turn off the popup.
Since other people seem to like it, let me use/review it more.
| src/ListTabbedSessionsPopup.cpp | ||
|---|---|---|
| 3 ↗ | (On Diff #49152) | You should place real copyright owner(s) here |
Comment Actions
"last used view" (or "next/prev tab"?) does the same thing without popup. Or have I missed something?
| src/ViewManager.cpp | ||
|---|---|---|
| 295 | I think Alt instead of Meta should be used - KDE applications do not usually use Meta for non-global things (AFAIR). | |
| 299 | Can you change this to be the shortcut from lastUsedViewAction + Shift? | |
Comment Actions
how that the splits are merged, I'm preparing a round of patches that where rotting in my pc.
Comment Actions
- Simplify handling of code
- Handle list with the shortcut selected
- Mostly working
- Remove mnemonics from text
Comment Actions
This is mostly working, but I will not merge this untill we fix the current state of the shortcuts (that I'm preparing in a separate patch).
after the shortcuts are correct, there will be a follow up patch here to use the switcher style *or* the next-prev-tab style (as we have today) selectable by the user, defaulting to the current behavior.