[RFC] [Splash Screen] Use current "Next" wallpaper as the background
Needs ReviewPublic

Authored by ngraham on Feb 26 2019, 9:43 PM.

Details

Reviewers
rooty
Group Reviewers
VDG
Plasma
Summary

The current Breeze splash screen is rather visually incongruous with what comes
immediately before and after it by default: before it is the login screen which
displays a blurred version of the current Next wallpaper by default, and after it
is the desktop, which, again, by default displays the current Next wallpaper.

This patch makes the Breeze theme splash screen use the same wallpaper, which
looks much better.

[RFC] because we should really use some CMake variables to build the first part of
the path like we do for the SDDM theme's config file. I couldn't figure out how to
do this though and need a little help.

Test Plan

(Looks better in person that it does in this crappy phone video)

Diff Detail

Repository
R120 Plasma Workspace
Branch
splash-screen-uses-next-wallpaper (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8909
Build 8927: arc lint + arc unit
ngraham created this revision.Feb 26 2019, 9:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 26 2019, 9:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 26 2019, 9:43 PM
rooty accepted this revision as: rooty.Feb 26 2019, 9:46 PM
rooty added a subscriber: rooty.

Wow that's fancy. +1

I only wish we could also change the Splash Screen background the same way we can change the sddm theme background.
Or better yet, have matching backgrounds so the login seems seamless.

But both of those are beyond the scope of this patch so....

This revision is now accepted and ready to land.Feb 26 2019, 9:46 PM
rooty added a comment.EditedFeb 26 2019, 9:48 PM

Hold on, could we?
If we created a symlink, say Background.png, in /usr/share/sddm/themes/breeze
Could we make the sddm theme and this splash screen use that same file?

Hence, matching backgrounds (the default would still be Next, of course)

filipf added a subscriber: filipf.Feb 26 2019, 9:48 PM

Finally! Now let's just get it to work.

lookandfeel/contents/splash/Splash.qml
28

This will get removed in D18006 so we should use 3840x2160.png instead

Hold on, could we?
If we created a symlink, say Background.png, in /usr/share/sddm/themes/breeze
Could we make the sddm theme and this splash screen use that same file?

Yes, it would be perfectly possible to do that. Whether or not this is desirable is another matter of course. :) We'd need to adjust the UI in the SDDM KCM to mention that it also affects the splash screen.

This occurred to me while I was making the patch, but I decided to leave it out for now. I think whether the login and splash screens should always have the same image is an interesting idea that needs more discussion before patches are submitted. :)

lookandfeel/contents/splash/Splash.qml
28

D18006 isn't going to land in 5.16 (if ever), so I would prefer to use the same value as the SDDM theme current uses to make sure that the visuals are identical. If and when D18006 lands, we do this there too.

rooty added a comment.EditedFeb 26 2019, 10:08 PM

I don't know... if we made the splash screen use the same image as the login screen, it would become an extension of the login screen.

Because otherwise, for a user that's using a third party wallpaper for the breeze sddm theme, you've got
(1) one wallpaper for the sddm theme
(2) another for the splash screen
(3) and a potential third wallpaper that differs from (1) and (2) provided they didn't use the same wallpaper for the sddm theme and their desktop wallpaper (which is only further complicated by having multiple users on the same computer that aren't all bound to have/use the same wallpaper).

That's a lot of wallpapers...

^ let's discuss it in a separate task (here's one technical caveat: people with different sddm themes having to select the breeze theme to change their splash screen), I agree that implementing it here would be rushing things

^ let's discuss it in a separate task (here's one technical caveat: people with different sddm themes having to select the breeze theme to change their splash screen), I agree that implementing it here would be rushing things

Agreed

rooty added a comment.Mar 5 2019, 3:03 AM

P.S. I've been using this for a couple of days now, and I really like it. Another idea (for another diff) - we could also ditch the "Plasma made by KDE" label and logo in the bottom right corner seeing as we already have the Plasma logo above the spinning circle? It makes it really subtle (and you know how I like subtlety haha)

The original rationale of the time of having the black background was to hide the flickering blank framebuffer as we switch from SDDM to the login - and we're autologigng in we're coming from a black background too. From a tech POV I like that because loading a wallpaper is quite CPU consuming.

I don't think we can ship anything without a config, if a user can configure login background and desktop background, showing a "random" wallpaper in the middle is bound to get a negative reaction.
And if we're going to put time into that, we may as well invest the time into getting rid of the splash screen (though properly, not just turning it off, but fixing why it's there)

Shipping this as a separate splash screen to the black might be an acceptable short term solution. Having new designs as opt-in first is something I would like to encourage.

rooty added a comment.Mar 5 2019, 3:08 PM

Wait so the flicker's fixable?

abetts added a subscriber: abetts.Mar 5 2019, 3:24 PM

+1 on looks

I don't think we can ship anything without a config, if a user can configure login background and desktop background, showing a "random" wallpaper in the middle is bound to get a negative reaction.

The idea we were toying with was to make the splash screen use the same image as the login screen, but in un-blurred form.

And if we're going to put time into that, we may as well invest the time into getting rid of the splash screen (though properly, not just turning it off, but fixing why it's there)

I would agree. If we can un-flicker Plasma, all the better!

rooty resigned from this revision.Thu, Mar 28, 11:22 PM
This revision now requires review to proceed.Thu, Mar 28, 11:22 PM