Differential D17629

Add method to BackgroundChecker to add word to session
ClosedPublic
Actions

Authored by ahmadsamir on Dec 16 2018, 6:04 PM.

Details

Reviewers
davidedmundson
cullmann
sandsmark
Commits
R246:511a9ba9edc3: Add method to BackgroundChecker to add word to session
Summary

Add a convience method to add a word to the session of the
BackgroundChecker speller.

Diff Detail

Repository
R246 Sonnet
Branch
addWordToSession (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6440
Build 6458: arc lint + arc unit
ahmadsamir created this revision.Dec 16 2018, 6:04 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 16 2018, 6:04 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ahmadsamir requested review of this revision.Dec 16 2018, 6:04 PM
sandsmark accepted this revision.Dec 22 2018, 11:00 PM
This revision is now accepted and ready to land.Dec 22 2018, 11:00 PM
ahmadsamir updated this revision to Diff 48217.Dec 26 2018, 10:39 AM

Fix commit message

ahmadsamir updated this revision to Diff 48218.Dec 26 2018, 10:41 AM
ahmadsamir edited the summary of this revision. (Show Details)

arc diff verbatim

cullmann requested changes to this revision.Dec 26 2018, 9:27 PM

The old API is lacking docs, too, but could we have some doxygen comment for this with some @since version, too?
Thanks.

This revision now requires changes to proceed.Dec 26 2018, 9:27 PM
ahmadsamir updated this revision to Diff 48336.Dec 29 2018, 9:53 AM

Add doxygen doc for the new method including @since

cullmann accepted this revision.Dec 29 2018, 12:19 PM

Thanks

This revision is now accepted and ready to land.Dec 29 2018, 12:19 PM
Closed by commit R246:511a9ba9edc3: Add method to BackgroundChecker to add word to session (authored by ahmadsamir, committed by cullmann). · Explain WhyDec 29 2018, 3:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48336

View Options

src/core/backgroundchecker.h

Loading...
View Options

src/core/backgroundchecker.cpp

Loading...