Details

Reviewers

davidedmundson
cullmann
sandsmark

Commits

R246:511a9ba9edc3: Add method to BackgroundChecker to add word to session

Summary

Add a convience method to add a word to the session of the
BackgroundChecker speller.

Diff Detail

Repository

R246 Sonnet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ahmadsamir created this revision.Dec 16 2018, 6:04 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptDec 16 2018, 6:04 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ahmadsamir requested review of this revision.Dec 16 2018, 6:04 PM

Harbormaster completed remote builds in B6081: Diff 47683.Dec 16 2018, 6:04 PM

ahmadsamir added reviewers: davidedmundson, cullmann.Dec 16 2018, 6:07 PM

ahmadsamir added a dependent revision: D17630: Don't re-mark words added/ignored to the dictionary as misspelled.Dec 16 2018, 6:17 PM

ahmadsamir added a reviewer: sandsmark.Dec 18 2018, 6:16 PM

sandsmark accepted this revision.Dec 22 2018, 11:00 PM

This revision is now accepted and ready to land.Dec 22 2018, 11:00 PM

Fix commit message

Harbormaster completed remote builds in B6366: Diff 48217.Dec 26 2018, 10:39 AM

arc diff verbatim

Harbormaster completed remote builds in B6367: Diff 48218.Dec 26 2018, 10:41 AM

The old API is lacking docs, too, but could we have some doxygen comment for this with some @since version, too?
Thanks.

This revision now requires changes to proceed.Dec 26 2018, 9:27 PM

Add doxygen doc for the new method including @since

Harbormaster completed remote builds in B6440: Diff 48336.Dec 29 2018, 9:53 AM

Thanks

This revision is now accepted and ready to land.Dec 29 2018, 12:19 PM

Closed by commit R246:511a9ba9edc3: Add method to BackgroundChecker to add word to session (authored by ahmadsamir, committed by cullmann). · Explain WhyDec 29 2018, 3:23 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/core/backgroundchecker.h (8 lines)
M			src/core/backgroundchecker.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47683	59fcd4b		Dec 16 2018, 6:04 PM	★	★
Diff 2	48217	59fcd4b	Fix commit message	Dec 26 2018, 10:39 AM	★	★
Diff 3	48218	59fcd4b	arc diff verbatim	Dec 26 2018, 10:41 AM	★	★
Diff 4	48336	59fcd4b	Add doxygen doc for the new method including @since	Dec 29 2018, 9:53 AM	★	★
Diff 5	48354	59fcd4b	R246:511a9ba9edc3e09ee884f6e72e1568664c6951e9	Dec 29 2018, 3:24 PM	★	★

	Status	Author	Revision
	Closed	ahmadsamir	D17630 Don't re-mark words added/ignored to the dictionary as misspelled
	Closed	ahmadsamir	D17629 Add method to BackgroundChecker to add word to session

Add method to BackgroundChecker to add word to session
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 48354

src/core/backgroundchecker.h

src/core/backgroundchecker.cpp

Add method to BackgroundChecker to add word to sessionClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 48354

src/core/backgroundchecker.h

src/core/backgroundchecker.cpp

Add method to BackgroundChecker to add word to session
ClosedPublic
Actions

Revision Contents
Changeset List