Don't re-mark words added/ignored to the dictionary as misspelled
ClosedPublic

Authored by ahmadsamir on Dec 16 2018, 6:17 PM.

Details

Summary

When a word is added to the dictionary or ignored via the spellingMenu,
the BackgroundChecker instance in ontheflycheck should be updated to
reflect the changes, otherwise words already added to the dictionary
(or ignored) are re-highlited as misspelled when the view changes.

Depends on D17629.

BUG: 387729

Test Plan
  • Open a file with misspelled words in kate and enable automatic spellchecking
  • Using the context menu:
    • add a misspelled word to the dictionary
    • Ignore another word B misspelling highlighting is removed, as expected
  • Scroll up/down so that those particular words are out of view then scroll and show them again; notice that those words re-highlighted as misspelled
  • After applying the pacth, words added/ingored to the dictionary aren't going to be re-highlighted as misspelled when the view changes

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Dec 16 2018, 6:17 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 16 2018, 6:17 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
ahmadsamir requested review of this revision.Dec 16 2018, 6:17 PM
cullmann accepted this revision.Dec 26 2018, 9:58 PM

Makes sense, will push that after you fix the documentation for the other patch, thanks!

This revision is now accepted and ready to land.Dec 26 2018, 9:58 PM
This revision was automatically updated to reflect the committed changes.