Make Status and Notification popup consistent with others.
ClosedPublic

Authored by shubham on Dec 13 2018, 9:03 AM.

Details

Summary
  1. Remove the left margin.
  2. Change '&' to "and".

Before:

After:

Test Plan

Open System Tray.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
shubham created this revision.Dec 13 2018, 9:03 AM
Restricted Application edited subscribers, added: plasma-devel; removed: Plasma. · View Herald TranscriptDec 13 2018, 9:03 AM
shubham requested review of this revision.Dec 13 2018, 9:03 AM
broulik added a reviewer: VDG.Dec 13 2018, 9:04 AM

I think the zero left margin looks odd, it should at least align with the icons. Also, this was originally done so it doesn't shift around as you switch between applets and the list.

@broulik In all others, if you notice it is 0

mart added a comment.Dec 13 2018, 11:34 AM

for it to be perfect looking, i think it should either be aligned to the left of the icons, or to the left of the text items

Just my 2Cents

I think the zero left margin looks odd, it should at least align with the icons.

i think it should either be aligned to the left of the icons, or to the left of the text items

I agree to both of you, but the title "Make Status and Notification popup consistent with others" is right. As it is now it fit perfect with the others when you click through your list of status bar icons. So with your suggestion should the others modified too.

The only thing I would like to see is that the applet is not hidden when you click on it while some other was shown (1). But that's out of the scope from this patch.

(1) To clarify, assume always nothing is shown:

  • Click Notification (Shown), Click again (Hidden) -> OK
  • Click Notification (Shown), Click e.g. Volume (Glides to Volume), Click Notification (Hidden) -> Bad! Should be shown and hidden when clicked again
abetts added a subscriber: abetts.Dec 13 2018, 3:18 PM

In general, this patch makes it better. However, I feel that all the items are simply too close to the left edge. Can you add some padding or margin to the left? Maybe something like 5 px?

shubham updated this revision to Diff 47552.Dec 14 2018, 9:37 AM
shubham edited the summary of this revision. (Show Details)
shubham removed a reviewer: hein.

use 5px margin

fabianr added inline comments.
applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
98

Please don't use hard coded margins, use smallSpacing instead.

See https://hig.kde.org/layout/units.html

mart requested changes to this revision.Dec 14 2018, 1:10 PM
This revision now requires changes to proceed.Dec 14 2018, 1:10 PM
shubham updated this revision to Diff 47562.Dec 14 2018, 1:41 PM

Use units.smallSpacing

shubham marked an inline comment as done.Dec 14 2018, 1:42 PM

Two more cents.

I feel that all the items are simply too close to the left edge.

I agree but currently fit the look with all other applets (at least have there, Volume/Clipboard/Bluetooth). Perhaps could that changed somehow globally?

mart accepted this revision.Dec 14 2018, 1:44 PM
This revision is now accepted and ready to land.Dec 14 2018, 1:44 PM
This comment was removed by shubham.
This revision was automatically updated to reflect the committed changes.