| cullmann | |
| cfeck |
| VDG | |
| Frameworks |
When a KDirOperator view is used in Detailed or Detailed Tree view, when there isn't enough horizontal space, the Name column currently gets squeezed and becomes illegible.
This patch fixes that by making the name column fixed-width so it never gets too small to read the contents; instead the view sprouts a horizontal scrollbar, which is preferable.
BUG: 401506
FIXED-IN: 5.54
In Kate's Filesystem Browser plugin sidebar view:
In the open/save dialog when there's not enough horizontal space:
In the open/save dialog when there is enough horizontal space:
In this case, the other columns no longer stick to the right size of the view when the window is resized, which maybe isn't as nice as current behavior. Open to suggestions.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
A slightly nicer solution would appear to be to keep column 0 using QHeaderView::Stretch like it already is, but give only that column a minimum size equal to the longest item. That way the name column would dynamically expand as the view was enlarged which keeps the other columns aligned to the right side, but would not compress as the view shrinks. Unfortunately this doesn't appear to be easily possible: https://bugreports.qt.io/browse/QTBUG-1248
Yeah, I do too. It's certainly more functional. Do you think I should just commit this now?
Cool, landing now. If I can get some assistance, I might try my hand at submitting a Qt patch to add the requested resize mode.
Hey, this change makes the file dialog crawl on big directories.
For me, going into /usr/include makes the whole application freeze.
We should consider reverting and trying a different approach.
Weird, but can confirm. :/ I guess the minimum width calculation for the name column is a non-trivial operation.
Actually I feel like this regressed the visuals for the file dialog itself in the name of improving the situation for apps that use this view in a sidebar.
Unfortunately, since it also regresses performance, I will be reverting it and and will look for another approach.