This is a proposal to modify the profile shortcuts behaviour:
instead of opening a new tab with the corresponding profile
they now switch the profile of the current terminal display.
FEATURE: 319926
Details
Details
- Reviewers
hindenburg tcanabrava - Group Reviewers
Konsole - Commits
- R319:d689ba5403ce: Profile shortcuts switch profile instead of opening new tab
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Branch
- arc_profileshortcuts (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5949 Build 5967: arc lint + arc unit
Comment Actions
I don't really know how to test this in the embedded terminal in Kate for example. Could someone provide some guidance ?
Comment Actions
You can try to use the demo_konsolepart in src/tests/demo_konsolepart/ - or try to copy the home built konsolepart.so to a location the other apps will find them. (Depending on OS/distro exampe: /usr/lib/x86_64-linux-gnu/qt5/plugins/). If you have your distros konsole/konsolepart installed, it might cause issues.
Comment Actions
I don't think I agree that using a profile shortcut should switch the current tab to that profile. What would be rationale for this change?
Comment Actions
I would say "Expectations", when I go to the profile I expect it to switch the currently focused terminal to that profile, if the button was labelled "new terminal with profile" then I would be against that change. I belive both variants could coexist.
Comment Actions
Two other things:
- there is already a shortcut to open a new tab (Ctrl-Shift-t), but nothing to change the profile of the current terminal. With this patch you can do everything from the keyboard.
- as suggested in FEATURE: 319926, some users (me included) would like to be able to quickly switch temporarily to another profile and back.
Comment Actions
I would say "Expectations", when I go to the profile I expect it to switch the currently focused terminal to that profile,
+1
Comment Actions
Can you look the change I requested - a quick coding here seems to work w/ the changes.
| src/SessionController.cpp | ||
|---|---|---|
| 226 | This isn't good; instead of putting getProfileList() in ViewManager, put it in ProfileManager (without QObject) and then do '_profileList = ProfileManager::instance()->getProfileList(); | |
Comment Actions
This is very nice - thanks for working on this and staying with it. Good catch with the read only code.
Comment Actions
Is anyone working on the ability to open a new profile? I ask this because I had a shortcut assigned to open a root shell (Ctrl+Alt+R) and was quite surprised to find out that it didn't work anynore with no way to get it back. This is not the same as opening a new tab and switching profiles, since that won't change the command that was started.
Please re-add the feature to open a new shell. Please make the key assignments in the user's config that opened new sessions still open new sessions. You can add new shortcuts for switching profiles, but they should not inherit the existing shortcuts.
Comment Actions
Anyone have anything to say about Thiago's comment? There's now only one shortcut to open a new tab.
Comment Actions
Something needs to be done here before 19.08. Since switching profiles doesn't not run the Command, it makes certain profiles worthless (root, ssh, etc). I'd be tempted to allow user to select what shortcut does per profile, switch or new.
Comment Actions
Sorry, I don't have much time for KDE lately unfortunately. As the author of this patch, I would have like to help ...
Just a quick thought: when switching profiles, could we simply run the command of the new profile if, and only if, it is different than the command of the profile we are leaving ?
Comment Actions
Running the command would be a step that needs fixed when switching profiles regardless. However, I think we need the option to have shortcuts open new profile tabs. I had plans to try to work on it this week and if I can't find something revert it for 19.08.
Comment Actions
Since actions: new tab with profile and switch to profile are already in menus, they could be added to Configure Shortcuts window (both actions for each profile). In such case shortcut editor in profile manager should be removed.