[componentchooser KCM] Make KIO browser option the fallback only and remove from the UI
Needs ReviewPublic

Authored by ngraham on Wed, Dec 5, 7:57 PM.

Details

Reviewers
None
Group Reviewers
Plasma
VDG
Summary

Right now the componentchooser KCM's browser module has a really confusing setting ("In an application based on the contents of the url") that's the default. There are ancient Buzailla tickets about this being confusing, and some users report that it actually does the wrong thing for certain URLs.

This patch removes the UI for this feature and, in conjunction with D17371, makes it a hidden fallback-only behavior for the rare case that there aren't any web browsers installed.

BUG: 100016
FIXED-IN: 5.15.0

Test Plan

Here's what it looks like now:

Verifications performed:

  • There are no actual settings or behavioral changes for any existing users, since browsers ask to set themselves as the default, and distros ship config files already specifying their preferred browser.
  • Changing the browser in the combobox correctly updates both ~/.config/kdeglobals and ~/.configmimeapps.list.
  • The combobox's default setting is now correctly identical to what ~/.config/mimeapps.list specifies, if anything.
  • KRun still does unnecessary URL introspection when there is in fact a default browser set in ~/.config/mimeapps.list but ~/.config/kdeglobals` doesn't have a default browser set, which is fixed separately in KIO with D17371.

Diff Detail

Repository
R119 Plasma Desktop
Branch
browser-chooser-service-and-exec-only (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5730
Build 5748: arc lint + arc unit
ngraham created this revision.Wed, Dec 5, 7:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Dec 5, 7:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Wed, Dec 5, 7:57 PM
ngraham edited the summary of this revision. (Show Details)Wed, Dec 5, 7:58 PM
ngraham edited the test plan for this revision. (Show Details)

and some users report that it actually does the wrong thing for certain URLs.

Bug reports are also an indication people use it.

I don't see a compelling reason to remove a feature.

and some users report that it actually does the wrong thing for certain URLs.

Bug reports are also an indication people use it.

Well, it's the default, so I think that goes without saying. :)

The reason for removing it is because it's not what people expect in the year 2018. When you open an HTTP or HTTPS link, you expect it to open in your browser, full stop.

abetts added a subscriber: abetts.Tue, Dec 11, 3:51 PM

Can the section title be called something different instead of using the word "Component"?